Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do you generate (German) holiday information? #4

Closed
croesch opened this issue Jul 9, 2019 · 2 comments
Closed

How do you generate (German) holiday information? #4

croesch opened this issue Jul 9, 2019 · 2 comments

Comments

@croesch
Copy link

croesch commented Jul 9, 2019

The data on holidata.net is outdated. Can you update the data or give me a hint how to generate holiday data by myself?

I tried cloning the repo, and following the installation instructions. But it seems like the CPP code doesn't do the generation.

So I tried to run the python code, but it doesn't contain the classes for German holiday data. Can you provide those? Is that the correct way to build data that holidata.net hosts?

I also saw GothenburgBitFactory/taskwarrior#2173 and question if that's the correct way how to insert holiday information into taskwarrior? Is it? If yes, why wasn't the PR merged and if no, why does the outdated data remain in the doc/rc package?

I'd be glad if you could answer my question and help me save my problem, thx! Btw. I really enjoy using taskwarrior and timew - these tools are awesome.

@croesch croesch changed the title How did you generate (German) holiday information? How do you generate (German) holiday information? Jul 9, 2019
@lauft
Copy link
Member

lauft commented Aug 28, 2019

So I tried to run the python code, but it doesn't contain the classes for German holiday data. Can you provide those? Is that the correct way to build data that holidata.net hosts?

This seems to be the correct way (as pointed out here) but as you said, the German holiday data is missing.

Another way could be to update the CSV file DE.csv manually by entering the required data.

@lauft
Copy link
Member

lauft commented Sep 19, 2019

The german locale has been updated for 2019 and 2020.
The new update process via holidata is still a bit cumbersome and needs documentation.

@lauft lauft closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants