Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic is not able to reset sound system if some thread is waiting for a mutex. #762

Closed
oleg68 opened this issue Oct 9, 2021 · 1 comment · Fixed by #784
Closed

Panic is not able to reset sound system if some thread is waiting for a mutex. #762

oleg68 opened this issue Oct 9, 2021 · 1 comment · Fixed by #784
Assignees
@oleg68
Labels
bug Something isn't working
Milestone
3.3.1

Comments

@oleg68
Copy link
Contributor

oleg68 commented Oct 9, 2021

After researching #702 it found out that Panic cann't process when some sound thread is waiting for a mutex.

Whatever the root cause of locking the mutex Panic should reset the sound system even if something goes wrong.
@oleg68 oleg68 added the bug Something isn't working label Oct 9, 2021
@oleg68 oleg68 mentioned this issue Oct 9, 2021
Closed
@oleg68 oleg68 added this to the 3.3.1 milestone Oct 9, 2021
@oleg68 oleg68 self-assigned this Oct 9, 2021
@oleg68 oleg68 mentioned this issue Oct 9, 2021
Merged
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 9, 2021
Added copyright headers GrandOrgue#762
0a62cb8
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 9, 2021
Fixed typo GrandOrgue#762
02ccb77
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 9, 2021
Added checking for the thread should stop to waiting thread routines G…
c0054df 
…randOrgue#762
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 9, 2021
Fixed typo GrandOrgue#762
3f52f28
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 9, 2021
Adopted GOSoundGroupWorkItem for breaking with Panic on Waiting Grand…
0351dc8 
…Orgue#762
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 11, 2021
Adopted GOSoundThread for breaking with Panic on Waiting GrandOrgue#762
c83fdf5
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 11, 2021
Added common threading definitions GrandOrgue#762
db4fba1
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 13, 2021
Support of stopping the thread in GOSoundWorkItem::Run GrandOrgue#762
562d518
@oleg68 oleg68 mentioned this issue Oct 13, 2021
Merged
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 14, 2021
Made GOSoundThread breakable GrandOrgue#762
d30f7a1
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 15, 2021
Added checking for the thread should stop to waiting thread routines G…
751b794 
…randOrgue#762
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 15, 2021
Adopted GOSoundGroupWorkItem for breaking with Panic on Waiting Grand…
fe6b957 
…Orgue#762
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 15, 2021
Added common threading definitions GrandOrgue#762
1f3434e
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
Attempt to make threading primitives breakable GrandOrgue#762
5a297bf
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
Attempt to make threading primitives breakable GrandOrgue#762
5a1a1ce
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
Using breakable synch primitives GrandOrgue#762
7b31b49
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
Make GOSOundBufferItem::Finish breakable GrandOrgue#762
f012b68
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
GOSoundOutputWorkItem: Renamed a parameter GrandOrgue#762
24eb91d
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 16, 2021
Made GOSoundOutputWorkItem breakable GrandOrgue#762
3f0f866
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 17, 2021
Attempt to make threading primitives breakable GrandOrgue#762
47e4c53
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 17, 2021
Using breakable synch primitives GrandOrgue#762
c771e79
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 17, 2021
Make GOSOundBufferItem::Finish breakable GrandOrgue#762
e206590
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 17, 2021
GOSoundOutputWorkItem: Renamed a parameter GrandOrgue#762
69fbadf
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 17, 2021
Made GOSoundOutputWorkItem breakable GrandOrgue#762
faf27a9
@oleg68 oleg68 mentioned this issue Oct 17, 2021
Merged
@oleg68
Copy link
Contributor Author

oleg68 commented Oct 17, 2021

References: #702

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg68 oleg68

Labels
bug Something isn't working
Projects
None yet
Milestone
3.3.1
Development

Successfully merging a pull request may close this issue.

Fixed hang on Panic button after the sound had been suddenly stopped oleg68/GrandOrgue-official
1 participant
@oleg68