Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/moving classes and files #765

Merged
merged 5 commits into from
Oct 10, 2021

Conversation

oleg68
Copy link
Contributor

@oleg68 oleg68 commented Oct 9, 2021

For working with #762 I did some beautification of the code without changing the behaviour.

I've tried to achieve

  • Each of threading classes has separated header (.h) and implementation (.cpp) file
  • The name of the files are the same as the names of the classes
  • All the files are in the separate directory src/core/threading

I made a separate PR for a part of changes because a lot of files had been affected with trivial changes (mostly the path of include file). It would be difficult to review them with essencial changes.

Oleg Samarin added 3 commits October 9, 2021 18:13
- All thread-related files were moved to the threading subdirectory
- Each class was moved to the separate file
- The names of header files became the same as the class names
- The code was not changed
Copy link
Contributor

@larspalo larspalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright header should be added to all the .cpp files too, right?

In src/core/threading/GOMutexLocker.h you have a typo for the #ifndef on line 7

@oleg68
Copy link
Contributor Author

oleg68 commented Oct 9, 2021

The copyright header should be added to all the .cpp files too, right?

In src/core/threading/GOMutexLocker.h you have a typo for the #ifndef on line 7

Fixed

@oleg68 oleg68 requested a review from larspalo October 9, 2021 19:37
@oleg68
Copy link
Contributor Author

oleg68 commented Oct 9, 2021

@rousseldenis ?

@oleg68 oleg68 merged commit 0a584a9 into GrandOrgue:master Oct 10, 2021
@oleg68 oleg68 deleted the bugfix/moving-classes-and-files branch October 16, 2021 06:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants