Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone element problem ! [mjml-preset] in Chrome #129

Closed
FlashPapa opened this issue Jun 28, 2017 · 2 comments
Closed

Clone element problem ! [mjml-preset] in Chrome #129

FlashPapa opened this issue Jun 28, 2017 · 2 comments
Labels

Comments

@FlashPapa
Copy link

Hi,
When copying an element the output does not take into account the changes !

I start with :\

<mjml>
  <mj-body>
    <mj-container>
      <mj-section>
        <mj-column>
          <mj-text>Content 1
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
        <mj-column>
          <mj-text>Content 2
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
      </mj-section>
    </mj-container>
  </mj-body>
</mjml>

I dupplicate the firt section '<mj-container>'

and i do 'view code' i have got :

<mjml>
  <mj-body>
    <mj-container>
      <mj-section>
        <mj-column>
          <mj-text>Content 1
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
        <mj-column>
          <mj-text>Content 2
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
      </mj-section>
      <mj-section>
        <mj-column>
          <mj-text>Content 1
          </mj-text>
          <mj-image/>
        </mj-column>
        <mj-column>
          <mj-text>Content 2
          </mj-text>
          <mj-image/>
        </mj-column>
      </mj-section>
    </mj-container>
  </mj-body>
</mjml>

that don't care about children element ?!

While we should have :

<mjml>
  <mj-body>
    <mj-container>
      <mj-section>
        <mj-column>
          <mj-text>Content 1
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
        <mj-column>
          <mj-text>Content 2
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
      </mj-section>
      <mj-section>
        <mj-column>
          <mj-text>Content 1
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
        <mj-column>
          <mj-text>Content 2
          </mj-text>
          <mj-image src="http://placehold.it/350x250/78c5d6/fff"/>
        </mj-column>
      </mj-section>
    </mj-container>
  </mj-body>
</mjml>
@artf
Copy link
Member

artf commented Jun 28, 2017

thanks for the catch @FlashPapa seems like it doesn't take into account styled attributes, but as it seems to be related only with mjml components I'll move it there

@artf artf closed this as completed Jun 28, 2017
@lock
Copy link

lock bot commented Sep 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants