Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: html-renderer #77

Merged
merged 24 commits into from
Apr 5, 2022
Merged

feat: html-renderer #77

merged 24 commits into from
Apr 5, 2022

Conversation

jpedroschmitz
Copy link
Contributor

@jpedroschmitz jpedroschmitz commented Mar 30, 2022

This PR creates the HTML Renderer package, which is framework-agnostic.


Relevant changes:

  • I moved a few types from the types package to the renderer packages since every renderer can have different types.
  • I'm still not sure about validations. Right now, I copied and pasted them from react-renderer to the html. But maybe in the future, we can create a validations package.
  • Two new examples, Svelte and Vue, both using the html-renderer
  • I moved the React example from Parcel to Vite. The new examples are also using Vite.
  • Closes Is there any way to render rich text in vue effectively? #63

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

🦋 Changeset detected

Latest commit: b89967d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphcms/rich-text-react-renderer Minor
@graphcms/rich-text-types Minor
@graphcms/rich-text-html-renderer Minor
@graphcms/html-to-slate-ast Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 5.23 KB (+2.04% 🔺)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 5.16 KB (+1.37% 🔺)
packages/types/dist/rich-text-types.cjs.production.min.js 0 B (-100% 🔽)
packages/types/dist/rich-text-types.esm.js 0 B (-100% 🔽)
packages/html-renderer/dist/rich-text-html-renderer.cjs.production.min.js 2.65 KB (+100% 🔺)
packages/html-renderer/dist/rich-text-html-renderer.esm.js 2.59 KB (+100% 🔺)

@jpedroschmitz
Copy link
Contributor Author

I think the PR is ready for review! cc @feychenie @larisachristie

@jpedroschmitz jpedroschmitz marked this pull request as ready for review April 4, 2022 14:31
@jpedroschmitz jpedroschmitz merged commit b7f16fa into main Apr 5, 2022
@jpedroschmitz jpedroschmitz deleted the html-renderer branch April 5, 2022 15:56
@github-actions github-actions bot mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there any way to render rich text in vue effectively?
2 participants