Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clipboard autoclear timeout setting #158

Open
wants to merge 170 commits into
base: 13
Choose a base branch
from
Open

Clipboard autoclear timeout setting #158

wants to merge 170 commits into from

Conversation

secrecyflag
Copy link

Adds a setting for the settings app in the Privacy menu.
Needs testing!

Android Build Coastguard Worker and others added 30 commits October 3, 2022 23:28
Snap for 9133013 from db09b99 to tm-qpr2-release
f356899 
Change-Id: I7ff83f8565e0d4de2232ec6631c9c75f2b4710a7
Snap for 9137459 from a94259a to tm-qpr2-release
594327a 
Change-Id: Ided1f283f27b20579d7f175aab5c300eda513946
Snap for 9148167 from 6ecbe4c to tm-qpr2-release
68acd3e 
Change-Id: I01868d8ec453a0bdef8e4277bfc9ccf372db18e7
Snap for 9153129 from da58404 to tm-qpr2-release
a1c0972 
Change-Id: I66ccfc6fdb83062c267a135ef098b6638847834e
Snap for 9154961 from 4fd86cc to tm-qpr2-release
a17bf20 
Change-Id: Iaa11309145b70aed6ac0052889b4993a77d2294c
Snap for 9163457 from d1dd162 to tm-qpr2-release
b1e0718 
Change-Id: Icefdc622990d64a5df353fcf35fbaca8ba306b61
Snap for 9167942 from 689350d to tm-qpr2-release
0165576 
Change-Id: I9f1186ef582ac81fe07abc293adfafacc42319c9
Snap for 9173498 from 236eaed to tm-qpr2-release
a402303 
Change-Id: I25115238064759b19ca848a34a3e66b2ef2e3ae4
Snap for 9178587 from 9f0efa6 to tm-qpr2-release
3ff82c4 
Change-Id: I5a2cccb7c797f090d1f86096bd88eb11aa19dff1
Snap for 9180607 from b2269ca to tm-qpr2-release
5f86fc0 
Change-Id: I50057a846d222b2175964a17bd015f65518a8553
Snap for 9185292 from 2fa81e2 to tm-qpr2-release
ea3ed21 
Change-Id: I26115a905c074ceb3f04344824b3b87dc4b093cc
Snap for 9190355 from 6a8e193 to tm-qpr2-release
2ae9163 
Change-Id: Iac7fb9f54e0b057617545e1aea78a7b225d015ae
Snap for 9195661 from 062b18c to tm-qpr2-release
edeefdb 
Change-Id: I596f85339f888ea43a6dea6be127197299661b06
Snap for 9206145 from f25d55b to tm-qpr2-release
c0156f0 
Change-Id: I467ecee41c760d226ad5d0f702eb3d3d17c0e5ce
Snap for 9211918 from 02cf722 to tm-qpr2-release
0884901 
Change-Id: Id065d2e3897ecdf149afecd376bd512dcb294675
Snap for 9217312 from d66e0c4 to tm-qpr2-release
2129524 
Change-Id: I3bff71eaaa0350a62d031b6fd4888a485ac33473
Snap for 9222401 from 9144681 to tm-qpr2-release
8214b05 
Change-Id: I3f483f189d41e66e828e2c983cdda3c6239c626c
Snap for 9227242 from f5a9766 to tm-qpr2-release
dc98170 
Change-Id: I14be7c0f7fffad7913e32ef6529a0a258859ff49
Snap for 9232464 from 47d84b4 to tm-qpr2-release
4bda871 
Change-Id: Ie525c7d06bc31b8200a04209626094f993b69a9c
Snap for 9238644 from b0f38d2 to tm-qpr2-release
89ae359 
Change-Id: Idf21da3c876559cf82997e9d4427a2154167951b
Snap for 9243084 from 1fa9870 to tm-qpr2-release
b102f33 
Change-Id: I5e4ae0591756eb597fd6ce402eaecd9b560173ac
Snap for 9248884 from 049deec to tm-qpr2-release
d3d36e1 
Change-Id: I3105814036d562c9ac0744ea536ca66fad60b850
@wescande
Fetch currently loaded bluetooth name
1b64234 
Test: m
ROBOTEST_FILTER="BluetoothMaxConnectedAudioDevicesPreferenceControllerTest"
RunSettingsRoboTests -j40

Test: Open developper settings
Bug: 257158801
Change-Id: Ib40a6264d8d6908103d76b6401ddcfd3ffa7dd88
(cherry picked from commit e2c6d1f60dde927daeb84226a1b025a582b2a9be)
Merged-In: Ib40a6264d8d6908103d76b6401ddcfd3ffa7dd88
Merge cherrypicks of [20378665] into tm-qpr2-release.
2b951b2 
Change-Id: I40280ea0b9f4cad14c4d478cdd754df8243695d6
Snap for 9253587 from 2552ae0 to tm-qpr2-release
73af591 
Change-Id: I27f90314524426eb601ce8676c5db14751951f13
@wescande
Fetch currently loaded bluetooth name
2e3e673 
Test: m
ROBOTEST_FILTER="BluetoothMaxConnectedAudioDevicesPreferenceControllerTest"
RunSettingsRoboTests -j40

Test: Open developper settings
Bug: 257158801
Change-Id: Ib40a6264d8d6908103d76b6401ddcfd3ffa7dd88
(cherry picked from commit e2c6d1f60dde927daeb84226a1b025a582b2a9be)
Merged-In: Ib40a6264d8d6908103d76b6401ddcfd3ffa7dd88
Merge cherrypicks of [20378665] into tm-qpr2-release.
112d890 
Change-Id: I4a43c239f41ffd17df5be2ce600dd0a7fa9edae3
Snap for 9257771 from bc38bac to tm-qpr2-release
d8ad5a7 
Change-Id: Ie592c9b64452a233a37a8876c54fbe00aba22482
Snap for 9261117 from 76f12cc to tm-qpr2-release
f7ea0f1 
Change-Id: If0ed09afe4ebd18a87bdf3d852763e6c968d3dd5
Snap for 9264471 from af96b1e to tm-qpr2-release
2f805f6 
Change-Id: Ieb8d80c1b32a7558b44a81ed57351b4a2202f441
@muhomorr @thestinger
fix visibility of AbstractTogglePrefController constructor
82226d4
@muhomorr @thestinger
reimplement toggle for privileged eSIM management
38a0b70 
Use it only for controlling the LPA app state, EuiccSupportPixel package is now handled separately.
@secrecyflag secrecyflag mentioned this pull request Mar 28, 2023
Closed
@girlbossceo
Copy link
Contributor

New GrapheneOS settings should be using our ExtSettings infrastructure. This makes it easier to port, make it cleaner, better runtime-wise, etc.

@girlbossceo
Copy link
Contributor

See 4297966 and 3416cf8 for examples

@secrecyflag
Copy link
Author

@r3g-5z Wish I knew about it before...

@secrecyflag
Copy link
Author

I can't actually test the feature in action, problems on my end. The build does pass.

@girlbossceo
Copy link
Contributor

@r3g-5z Wish I knew about it before...

It's a new thing and we haven't fully ported all our existing settings to it, but we will eventually document it either as a GrapheneOS feature or in our development guidelines.

girlbossceo
girlbossceo suggested changes Apr 1, 2023
View reviewed changes
res/xml/privacy_controls_settings.xml Outdated Show resolved Hide resolved
@secrecyflag secrecyflag marked this pull request as ready for review April 2, 2023 15:09
girlbossceo
girlbossceo suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@girlbossceo girlbossceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight style changes here

res/xml/privacy_controls_settings.xml Outdated Show resolved Hide resolved
src/com/android/settings/privacy/ClipboardTimeoutController.java Outdated Show resolved Hide resolved
src/com/android/settings/privacy/ClipboardTimeoutController.java Outdated Show resolved Hide resolved
src/com/android/settings/privacy/ClipboardTimeoutController.java Show resolved Hide resolved
src/com/android/settings/privacy/ClipboardTimeoutController.java Outdated Show resolved Hide resolved
@girlbossceo girlbossceo self-assigned this Apr 3, 2023
girlbossceo
girlbossceo approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@girlbossceo girlbossceo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerns have been addressed and feature works

Must be squashed when merged

girlbossceo and others added 3 commits April 4, 2023 01:41
@girlbossceo @thestinger
Revert "attestation key provisioning server setting"
5e320c9 
This reverts commit 6a01dc7.
@girlbossceo @flawedworld @thestinger
attestation key provisioning server setting
7f21d32 
Co-authored-by: flawedworld <flawedworld@flawed.world>
Signed-off-by: r3g_5z <june@girlboss.ceo>
@secrecyflag
Clipboard auto-clear timeout setting
70dd230
@secrecyflag
Copy link
Author

re-based successfully. the feature should be ready now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girlbossceo girlbossceo girlbossceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone