Skip to content

Commit

Permalink
Fix assets compression on production builds (#5527) (#5534)
Browse files Browse the repository at this point in the history
Due to a bug in uglify-js 3.4.9, compressing conditionals during asset
minimization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

There are several reports in the upstream project, one of them is:
mishoo/UglifyJS#3269

Fixes #5450

(cherry picked from commit 28993f9)
  • Loading branch information
edmundoa authored and bernd committed Jan 17, 2019
1 parent 255cbfa commit 62d6fe4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions graylog2-web-interface/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,10 @@ if (TARGET === 'build') {
minimize: true,
sourceMap: true,
compress: {
// Conditionals compression caused issue #5450 so they should be disabled for now.
// Looking at uglify-js issues, it seems that the latest changes in version 3.4.9 broke conditionals
// compression. For example: https://github.com/mishoo/UglifyJS2/issues/3269
conditionals: false,
warnings: false,
},
mangle: {
Expand Down

0 comments on commit 62d6fe4

Please sign in to comment.