Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Values not working right in 3.0 beta 1 #5450

Closed
kpointer opened this issue Jan 3, 2019 · 4 comments · Fixed by #5527
Closed

Quick Values not working right in 3.0 beta 1 #5450

kpointer opened this issue Jan 3, 2019 · 4 comments · Fixed by #5527
Assignees
Labels
blocker If not finished by release date, the release will be postponed. bug #M > 1d <= 3d triaged
Milestone

Comments

@kpointer
Copy link

kpointer commented Jan 3, 2019

When doing a search and selecting quick values on a field, duplicate entries are shown and the sorting seems to be random.

screen shot 2019-01-03 at 1 35 05 pm

Expected Behavior

Quick Values should have the correct data.

Current Behavior

Steps to Reproduce (for bugs)

  1. Do a search
  2. Select a field and choose the Quick Values

Your Environment

  • Graylog Version: 3.0 beta 1
  • Elasticsearch Version: 5.6.14
  • MongoDB Version: 3.6.9
  • Operating System: Ubuntu 16.04 LTS
  • Browser version: Firefox 65.0b7 / Safari 12.0.2
@jalogisch
Copy link
Contributor

Could you please provide us with the following information:

  • what field type did you have on the data in ES?
  • does that happen always on all fields or only on that single one?
  • is this reproducible at any time?

@kpointer
Copy link
Author

kpointer commented Jan 7, 2019

what field type did you have on the data in ES?

Most are keyword, but the source field is {"type":"text","analyzer":"analyzer_keyword","fielddata":true}

does that happen always on all fields or only on that single one?

I'm seeing it with every field I try. I first saw it with my top hosts widget, which is using source. If i do a 5 minute search and try doing quickvalues on various fields, all that I try will have random duplicate entries and the majority won't be sorted correctly.

is this reproducible at any time?

So far it is.

@no-response no-response bot removed the needs-input label Jan 7, 2019
@bernd
Copy link
Member

bernd commented Jan 9, 2019

I can reproduce this on my test setup.

It seems to be an UI issue because the API response from the Graylog server doesn't contain any duplicate values but the widget shows duplicate ones and the sorting is wrong.

@bernd bernd added blocker If not finished by release date, the release will be postponed. bug #M > 1d <= 3d and removed to-verify labels Jan 9, 2019
@bernd bernd added this to the 3.0.0 milestone Jan 9, 2019
@edmundoa edmundoa self-assigned this Jan 11, 2019
@edmundoa
Copy link
Contributor

After looking into this on Friday, I could not point to any change in the quick values widget that explains this change of behaviour. I could not reproduce the issue in a 2.5 build, but using the same widget code that we had in 2.5 in a 3.0 build (only replacing the deprecated React.createClass with createReacClass) also showed the described issue.

Trying to find the culprit of the issue I disabled JS minimization in the build process and that fixed the issue for me. As we changed the way we minimize assets on 3.0, I think we need to review our minimization options to see if they are doing something they should not do.

edmundoa pushed a commit that referenced this issue Jan 16, 2019
Due to a bug in uglify-js 3.4.9 compressing conditionals during asset
minization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

Here is a similar issue reported in upstream project:
mishoo/UglifyJS#3269

Fixes #5450
edmundoa pushed a commit that referenced this issue Jan 16, 2019
Due to a bug in uglify-js 3.4.9, compressing conditionals during asset
minimization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

There are several reports in the upstream project, one of them is:
mishoo/UglifyJS#3269

Fixes #5450
bernd pushed a commit that referenced this issue Jan 16, 2019
Due to a bug in uglify-js 3.4.9, compressing conditionals during asset
minimization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

There are several reports in the upstream project, one of them is:
mishoo/UglifyJS#3269

Fixes #5450
edmundoa added a commit that referenced this issue Jan 17, 2019
Due to a bug in uglify-js 3.4.9, compressing conditionals during asset
minimization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

There are several reports in the upstream project, one of them is:
mishoo/UglifyJS#3269

Fixes #5450

(cherry picked from commit 28993f9)
bernd pushed a commit that referenced this issue Jan 17, 2019
Due to a bug in uglify-js 3.4.9, compressing conditionals during asset
minimization is broken, leading to #5450.

This commit disables conditionals compression until we can test it is fixed
in a future uglify-js release.

There are several reports in the upstream project, one of them is:
mishoo/UglifyJS#3269

Fixes #5450

(cherry picked from commit 28993f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker If not finished by release date, the release will be postponed. bug #M > 1d <= 3d triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants