Validate that Elasticsearch home/data paths are readable #2538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new ValidationException("Path " + path.toAbsolutePath() + " is not a directory."); | ||
| } | ||
|
|
||
| if (Files.exists(path) && !Files.isReadable(path)) { |
There was a problem hiding this comment.
Is there a case where the directory also needs to be writable? If so, we should also test for that.
There was a problem hiding this comment.
It has to be writable if data is being stored (elasticsearch_node_data). Other than that, I haven't found a case for which it had to be writable.
Funny enough, the directories don't even have to exist, it's sufficient if the parent directory is there.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These validations will ensure that cases like #2536 result in a better error message.