Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloning streams and editing legacy stream rules #2646

Merged
merged 2 commits into from Aug 10, 2016
Merged

Fix cloning streams and editing legacy stream rules #2646

merged 2 commits into from Aug 10, 2016

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Aug 9, 2016

  • The "description" field of stream rules wasn't cloned when cloning streams,
  • The "description" field in the CreateStreamRuleRequest class wasn't nullable which effectively prevented editing legacy stream rules without any description.

Refs #2244
Fixes #2346

Jochen Schalanda added 2 commits August 9, 2016 16:55
Add stream rule description when cloning streams
05d923d 
Fixes #2346
Make CreateStreamRuleRequest#description() nullable
e5b98d9 
The "description" field of stream rules has to be nullable because otherwise
legacy stream rules with no description cannot be edited anymore.

Refs #2244, fixes #2346
@joschi joschi added this to the 2.1.0 milestone Aug 9, 2016
@bernd bernd self-assigned this Aug 10, 2016
@bernd
Copy link
Member

bernd commented Aug 10, 2016

LGTM 👍

@bernd bernd merged commit 101bbf7 into master Aug 10, 2016
@bernd bernd deleted the issue-2346 branch August 10, 2016 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bernd bernd

Labels
bug ready-for-review
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joschi @bernd