Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE and verbose logging if converter returns null #2729

Merged
merged 1 commit into from
Aug 23, 2016
Merged

Prevent NPE and verbose logging if converter returns null #2729

merged 1 commit into from
Aug 23, 2016

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Aug 23, 2016

Converters can return null which should be properly handled by the Extractor class instead of just catching the "exception" (which really isn't one).

Refs #2717

@joschi joschi added this to the 2.1.0 milestone Aug 23, 2016
@edmundoa edmundoa self-assigned this Aug 23, 2016
@edmundoa
Copy link
Contributor

LGTM 👍

@edmundoa edmundoa merged commit ee9653a into master Aug 23, 2016
@edmundoa edmundoa deleted the issue-2717-npe branch August 23, 2016 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edmundoa edmundoa

Labels
improvement ready-for-review
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joschi @edmundoa