New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard layout broken when dashboard is created from content pack #3765

Closed
edmundoa opened this Issue May 3, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented May 3, 2017

Expected Behaviour

Layout of dashboards created from content packs looks fine, even if the widget had no width and height information.

Current Behaviour

Layout of dashboards created from content packs is broken when widget does not include width and/or height information.

Steps to Reproduce (for bugs)

  1. Import and apply a content pack including a dashboard, like: https://github.com/Graylog2/omnibus-graylog2/blob/294decadc40183f47e738b0c9c70df93aedaaac9/files/data/contentpacks/content_pack_appliance.json
  2. Go to the dashboard created from the content pack and see that the layout is broken

Your Environment

  • Graylog Version: Graylog 2.3.0-alpha.1

@edmundoa edmundoa added bug web labels May 3, 2017

@edmundoa edmundoa added this to the 2.3.0 milestone May 3, 2017

@edmundoa edmundoa self-assigned this May 3, 2017

edmundoa added a commit that referenced this issue May 3, 2017

Fix dashboard layouts when width or height is 0
Dashboards created from content packs always get a value for each widget
dimensions, being 0 the default. This behaviour is different than what
happens when a widget is created manually and is now taken into
account.

Fixes #3765

@edmundoa edmundoa added the in progress label May 3, 2017

@jalogisch jalogisch added the triaged label May 8, 2017

edmundoa added a commit that referenced this issue May 8, 2017

Fix dashboard layouts when width or height is 0
Dashboards created from content packs always get a value for each widget
dimensions, being 0 the default. This behaviour is different than what
happens when a widget is created manually and is now taken into
account.

Fixes #3765

@joschi joschi closed this in #3766 May 8, 2017

@wafflebot wafflebot bot removed the in progress label May 8, 2017

joschi added a commit that referenced this issue May 8, 2017

Fix dashboard layouts when width/height aren't positive integers (#3766)
Dashboards created from content packs always get a value for each widget
dimensions, being 0 the default. This behaviour is different than what
happens when a widget is created manually and is now taken into
account.

Fixes #3765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment