Add "replace" query param to Grok bulk import REST API endpoint. #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -104,6 +107,9 @@ public Response bulkUpdatePatterns(@ApiParam(name = "patterns", required = true) | |||
| throw new ValidationException("Invalid pattern " + pattern + ". Did not save any patterns."); | |||
| } | |||
| } | |||
| if (replace) { | |||
There was a problem hiding this comment.
This logic should be moved into GrokPatternService.
There was a problem hiding this comment.
Then we have to move the pattern creation as well. Any suggestion for method names?
Existing Grok patterns will be removed before adding the new ones if set to true. Fixes #937 Refs graylog-labs/graylog2-web-interface#1150
joschi
added a commit
that referenced
this pull request
Mar 5, 2015
Add "replace" query param to Grok bulk import REST API endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing Grok patterns will be removed before adding the new ones if set
to true.
Fixes #937
Refs graylog-labs/graylog2-web-interface#1150