Fix extractor date converters (#11750) (4.2 backport) #11774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix regression when using date converter #11495 * get tests passing * Run timestamp fallback conversion If the converter fails for a timestamp value, run the fallback timestamp conversion, to ensure that a Message always has a valid timestamp. * Add tests * Improve gl2_processing_error message Showing only the details is not helpful in some cases. * Improve converter code We don't need to call removeField before addField. It will just overwrite the value anyway. This avoids having to recalculate the message size twice. Only null values don't get set. Those we need to remove explicitly. * adjust test to new processing error output * improve comments Co-authored-by: Marco Pfatschbacher <marco@graylog.com> (cherry picked from commit d12d846)
mpfz0r
added
backport
blocker
patrickmann
approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression when using date converter processing error after migrating to 4.2.0-3 #11495
get tests passing
Run timestamp fallback conversion
If the converter fails for a timestamp value,
run the fallback timestamp conversion, to ensure that a Message
always has a valid timestamp.
Add tests
Improve gl2_processing_error message
Showing only the details is not helpful in some cases.
We don't need to call removeField before addField.
It will just overwrite the value anyway.
This avoids having to recalculate the message size twice.
Only null values don't get set. Those we need to remove explicitly.
adjust test to new processing error output
improve comments
Co-authored-by: Marco Pfatschbacher marco@graylog.com
(cherry picked from commit d12d846)