Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extractor date converters (#11750) (4.2 backport) #11774

Merged
merged 1 commit into from
Dec 9, 2021

Commits on Dec 8, 2021

  1. Fix extractor date converters (#11750)

    * Fix regression when using date converter #11495
    
    * get tests passing
    
    * Run timestamp fallback conversion
    
    If the converter fails for a timestamp value,
    run the fallback timestamp conversion, to ensure that a Message
    always has a valid timestamp.
    
    * Add tests
    
    * Improve gl2_processing_error message
    
    Showing only the details is not helpful in some cases.
    
    * Improve converter code
    
    We don't need to call removeField before addField.
    It will just overwrite the value anyway.
    This avoids having to recalculate the message size twice.
    
    Only null values don't get set. Those we need to remove explicitly.
    
    * adjust test to new processing error output
    
    * improve comments
    
    Co-authored-by: Marco Pfatschbacher <marco@graylog.com>
    (cherry picked from commit d12d846)
    patrickmann authored and mpfz0r committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    1ac125f View commit details
    Browse the repository at this point in the history