Log operating system details on server startup #1553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Tools.getSystemInformation(), configuration.getInstallationSource()); | ||
| final OS os = OS.getOs(); | ||
|
|
||
| LOG.info("Graylog {} {} starting up (JRE: {}, installed from: {}, OS: {})", commandName, version, |
There was a problem hiding this comment.
This is starting to get convoluted. Shouldn't we print each of these information nuggets in a separate line?
There was a problem hiding this comment.
Sure, we can do that. I wanted to save some log lines. 😜
Something like this?
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Graylog server 1.3.0-SNAPSHOT (91bbaeb) starting up
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Java Version: Oracle Corporation 1.8.0_66 on Linux 3.19.0-32-generic
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Installation Source: deb
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - OS: Ubuntu 14.04.3 LTS (trusty)
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Arch: amd64
There was a problem hiding this comment.
"JVM" instead of "Java Version" would be more concise and I'm somehow wondering if we can find a better term for "Installation source".
|
Log output looks like this now: |
|
LGTM. 👍 |
joschi
added a commit
that referenced
this pull request
Nov 12, 2015
Log operating system details on server startup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1244