New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log operating system details on server startup #1553

Merged
merged 1 commit into from Nov 12, 2015

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Nov 11, 2015

Fixes #1244

@bernd bernd added this to the 1.3.0 milestone Nov 11, 2015

Tools.getSystemInformation(), configuration.getInstallationSource());
final OS os = OS.getOs();
LOG.info("Graylog {} {} starting up (JRE: {}, installed from: {}, OS: {})", commandName, version,

This comment has been minimized.

@joschi

joschi Nov 11, 2015

Contributor

This is starting to get convoluted. Shouldn't we print each of these information nuggets in a separate line?

This comment has been minimized.

@bernd

bernd Nov 11, 2015

Member

Sure, we can do that. I wanted to save some log lines. 😜
Something like this?

2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Graylog server 1.3.0-SNAPSHOT (91bbaeb) starting up
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Java Version: Oracle Corporation 1.8.0_66 on Linux 3.19.0-32-generic
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Installation Source: deb
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - OS: Ubuntu 14.04.3 LTS (trusty)
2015-11-11 17:35:14,679 INFO : org.graylog2.bootstrap.ServerBootstrap - Arch: amd64

This comment has been minimized.

@joschi

joschi Nov 11, 2015

Contributor

"JVM" instead of "Java Version" would be more concise and I'm somehow wondering if we can find a better term for "Installation source".

This comment has been minimized.

@bernd

bernd Nov 11, 2015

Member

"Deployment: deb" ?

This comment has been minimized.

@joschi

joschi Nov 12, 2015

Contributor

👍

@joschi joschi self-assigned this Nov 11, 2015

@bernd bernd force-pushed the issue-1244 branch from 91bbaeb to 3b49808 Nov 12, 2015

@bernd

This comment has been minimized.

Member

bernd commented Nov 12, 2015

Log output looks like this now:

2015-11-12 11:39:45,096 INFO : org.graylog2.bootstrap.ServerBootstrap - Graylog server 1.3.0-SNAPSHOT (3b49808) starting up
2015-11-12 11:39:45,097 INFO : org.graylog2.bootstrap.ServerBootstrap - JRE: Oracle Corporation 1.8.0_66 on Linux 3.19.0-32-generic
2015-11-12 11:39:45,097 INFO : org.graylog2.bootstrap.ServerBootstrap - Deployment: unknown
2015-11-12 11:39:45,097 INFO : org.graylog2.bootstrap.ServerBootstrap - OS: Ubuntu 14.04.3 LTS (trusty)
2015-11-12 11:39:45,097 INFO : org.graylog2.bootstrap.ServerBootstrap - Arch: amd64
@joschi

This comment has been minimized.

Contributor

joschi commented Nov 12, 2015

LGTM. 👍

joschi added a commit that referenced this pull request Nov 12, 2015

Merge pull request #1553 from Graylog2/issue-1244
Log operating system details on server startup

@joschi joschi merged commit 1209abd into 1.3 Nov 12, 2015

3 checks passed

ci Jenkins build graylog2-server-integration-pr 356 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the issue-1244 branch Nov 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment