Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves session id to username in RestAccessLogFilter #1918

Merged
merged 3 commits into from Mar 17, 2016

Conversation

@mikkolehtisalo
Copy link
Contributor

@mikkolehtisalo mikkolehtisalo commented Mar 9, 2016

2.x broke logging username in RestAccessLogFilter, the session id got logged instead. This change resolves the session id back to actual username for audit logging purposes.

@joschi
Copy link
Contributor

@joschi joschi commented Mar 10, 2016

@mikkolehtisalo Thank you for your contribution to Graylog!

Before we can accept any code from you, we need you to sign our Contributor License Agreement. Please send us a signed copy to hello@graylog.com so we can merge your code. This is only required once, no matter how much contributions you make in the future. Thank you for helping us with this unfortunate administrative requirement!

@joschi joschi added this to the 2.0.0 milestone Mar 10, 2016
@joschi joschi self-assigned this Mar 10, 2016
@mikkolehtisalo
Copy link
Contributor Author

@mikkolehtisalo mikkolehtisalo commented Mar 10, 2016

@joschi
Copy link
Contributor

@joschi joschi commented Mar 10, 2016

@mikkolehtisalo I couldn't find your CLA in our documents. Sorry for the additional trouble.

@kroepke
Copy link
Member

@kroepke kroepke commented Mar 16, 2016

We have the CLA on file here, this is fine to review and merge from that perspective.

@kroepke kroepke assigned bernd and unassigned joschi Mar 17, 2016
bernd added a commit that referenced this pull request Mar 17, 2016
Resolves session id to username in RestAccessLogFilter
@bernd bernd merged commit 67fd38b into Graylog2:master Mar 17, 2016
3 checks passed
3 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 734 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 224 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bernd
Copy link
Member

@bernd bernd commented Mar 17, 2016

@mikkolehtisalo Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.