Resolves session id to username in RestAccessLogFilter #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikkolehtisalo Thank you for your contribution to Graylog! Before we can accept any code from you, we need you to sign our Contributor License Agreement. Please send us a signed copy to hello@graylog.com so we can merge your code. This is only required once, no matter how much contributions you make in the future. Thank you for helping us with this unfortunate administrative requirement! |
|
Hello. I already did, in January and to contributor@ as instructed o the
web pages. Resent just now to hello@
|
|
@mikkolehtisalo I couldn't find your CLA in our documents. Sorry for the additional trouble. |
|
We have the CLA on file here, this is fine to review and merge from that perspective. |
bernd
added a commit
that referenced
this pull request
Mar 17, 2016
Resolves session id to username in RestAccessLogFilter
|
@mikkolehtisalo Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.x broke logging username in RestAccessLogFilter, the session id got logged instead. This change resolves the session id back to actual username for audit logging purposes.