Fix extractor and static fields creation in multi-node setups #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extractor and static fields resource was using the local input registry to check if an input exists. This breaks in a multi-node setup where the web interface runs on node A and the input on node B. Fixes #2580
| } | ||
|
|
||
| final Input mongoInput = inputService.find(input.getPersistId()); | ||
| final Input mongoInput = inputService.find(inputId); |
There was a problem hiding this comment.
I think we should test for null here. If we don't it's probably harmless, but the error wouldn't be nice.
There was a problem hiding this comment.
InputService#find() throws a NotFoundException when the input cannot be found.
|
other than the |
|
LGTM. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extractor and static fields resource was using the local input
registry to check if an input exists. This breaks in a multi-node setup
where the web interface runs on node A and the input on node B.
Fixes #2580