Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move link to API Browser into System menu" #2587

Merged
merged 4 commits into from Aug 3, 2016
Merged

Revert "Move link to API Browser into System menu" #2587

merged 4 commits into from Aug 3, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Aug 2, 2016

This reverts commit b6fe1a9.

@joschi joschi added this to the 2.1.0 milestone Aug 2, 2016
@@ -29,6 +29,10 @@ const NodeMaintenanceDropdown = React.createClass({
<MenuItem>Configure internal logging</MenuItem>
</LinkContainer>
</IfPermitted>

<MenuItem href={`${this.props.node.transport_address}api-browser`} target="_blank">

This comment has been minimized.

@edmundoa

edmundoa Aug 2, 2016
Member

Could you please construct this link like we do with the one in NodesActions? Something like:

new URI(`${this.props.node.transport_address}/api-browser`).normalizePathname();

I think we could add a component that unifies both usages, I leave it up to you.

@bernd bernd self-assigned this Aug 3, 2016
@bernd
Copy link
Member

@bernd bernd commented Aug 3, 2016

LGTM 👍

@bernd bernd merged commit 981ef53 into master Aug 3, 2016
0 of 4 checks passed
0 of 4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1214 is running
Details
@garybot2
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@bernd bernd deleted the revert-pr-2361 branch Aug 3, 2016
mpfz0r added a commit that referenced this pull request Oct 10, 2019
Usually, the link to the API browser is meant to talk to one specific node only.

In cases where Graylog is served behind a load balancer, the node
specific URL is not reachable.
We autodetect that ( `http_external_uri` != `http_publish_uri` )
and display a "cluster global API browser button".

Since the API browser behind this address might end up talking
to random nodes of the cluster, display a warning box, to make
users aware of this.

Fixes #5920

Refs #2360
Refs #2587
bernd added a commit that referenced this pull request Oct 22, 2019
* Introduce a cluster global API browser button

Usually, the link to the API browser is meant to talk to one specific node only.

In cases where Graylog is served behind a load balancer, the node
specific URL is not reachable.
We autodetect that ( `http_external_uri` != `http_publish_uri` )
and display a "cluster global API browser button".

Since the API browser behind this address might end up talking
to random nodes of the cluster, display a warning box, to make
users aware of this.

Fixes #5920

Refs #2360
Refs #2587

* Fix review comments
bernd added a commit that referenced this pull request Oct 22, 2019
* Introduce a cluster global API browser button

Usually, the link to the API browser is meant to talk to one specific node only.

In cases where Graylog is served behind a load balancer, the node
specific URL is not reachable.
We autodetect that ( `http_external_uri` != `http_publish_uri` )
and display a "cluster global API browser button".

Since the API browser behind this address might end up talking
to random nodes of the cluster, display a warning box, to make
users aware of this.

Fixes #5920

Refs #2360
Refs #2587

* Fix review comments

(cherry picked from commit 6ac71c0)
mpfz0r added a commit that referenced this pull request Oct 23, 2019
* Introduce a cluster global API browser button (#6567)

* Introduce a cluster global API browser button

Usually, the link to the API browser is meant to talk to one specific node only.

In cases where Graylog is served behind a load balancer, the node
specific URL is not reachable.
We autodetect that ( `http_external_uri` != `http_publish_uri` )
and display a "cluster global API browser button".

Since the API browser behind this address might end up talking
to random nodes of the cluster, display a warning box, to make
users aware of this.

Fixes #5920

Refs #2360
Refs #2587

* Fix review comments

(cherry picked from commit 6ac71c0)

* Remove unused Alert import

* Fix propTypes in NodesList component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants