Revert "Move link to API Browser into System menu" #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b6fe1a9.
| @@ -29,6 +29,10 @@ const NodeMaintenanceDropdown = React.createClass({ | |||
| <MenuItem>Configure internal logging</MenuItem> | |||
| </LinkContainer> | |||
| </IfPermitted> | |||
|
|
|||
| <MenuItem href={`${this.props.node.transport_address}api-browser`} target="_blank"> | |||
There was a problem hiding this comment.
Could you please construct this link like we do with the one in NodesActions? Something like:
new URI(`${this.props.node.transport_address}/api-browser`).normalizePathname();I think we could add a component that unifies both usages, I leave it up to you.
|
LGTM 👍 |
mpfz0r
added a commit
that referenced
this pull request
Oct 10, 2019
Usually, the link to the API browser is meant to talk to one specific node only. In cases where Graylog is served behind a load balancer, the node specific URL is not reachable. We autodetect that ( `http_external_uri` != `http_publish_uri` ) and display a "cluster global API browser button". Since the API browser behind this address might end up talking to random nodes of the cluster, display a warning box, to make users aware of this. Fixes #5920 Refs #2360 Refs #2587
bernd
pushed a commit
that referenced
this pull request
Oct 22, 2019
* Introduce a cluster global API browser button Usually, the link to the API browser is meant to talk to one specific node only. In cases where Graylog is served behind a load balancer, the node specific URL is not reachable. We autodetect that ( `http_external_uri` != `http_publish_uri` ) and display a "cluster global API browser button". Since the API browser behind this address might end up talking to random nodes of the cluster, display a warning box, to make users aware of this. Fixes #5920 Refs #2360 Refs #2587 * Fix review comments
bernd
pushed a commit
that referenced
this pull request
Oct 22, 2019
* Introduce a cluster global API browser button Usually, the link to the API browser is meant to talk to one specific node only. In cases where Graylog is served behind a load balancer, the node specific URL is not reachable. We autodetect that ( `http_external_uri` != `http_publish_uri` ) and display a "cluster global API browser button". Since the API browser behind this address might end up talking to random nodes of the cluster, display a warning box, to make users aware of this. Fixes #5920 Refs #2360 Refs #2587 * Fix review comments (cherry picked from commit 6ac71c0)
mpfz0r
pushed a commit
that referenced
this pull request
Oct 23, 2019
* Introduce a cluster global API browser button (#6567) * Introduce a cluster global API browser button Usually, the link to the API browser is meant to talk to one specific node only. In cases where Graylog is served behind a load balancer, the node specific URL is not reachable. We autodetect that ( `http_external_uri` != `http_publish_uri` ) and display a "cluster global API browser button". Since the API browser behind this address might end up talking to random nodes of the cluster, display a warning box, to make users aware of this. Fixes #5920 Refs #2360 Refs #2587 * Fix review comments (cherry picked from commit 6ac71c0) * Remove unused Alert import * Fix propTypes in NodesList component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b6fe1a9.