New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move link to API Browser into System menu" #2587

Merged
merged 4 commits into from Aug 3, 2016

Conversation

Projects
None yet
3 participants
@joschi
Contributor

joschi commented Aug 2, 2016

This reverts commit b6fe1a9.

@joschi joschi added this to the 2.1.0 milestone Aug 2, 2016

@@ -29,6 +29,10 @@ const NodeMaintenanceDropdown = React.createClass({
<MenuItem>Configure internal logging</MenuItem>
</LinkContainer>
</IfPermitted>
<MenuItem href={`${this.props.node.transport_address}api-browser`} target="_blank">

This comment has been minimized.

@edmundoa

edmundoa Aug 2, 2016

Member

Could you please construct this link like we do with the one in NodesActions? Something like:

new URI(`${this.props.node.transport_address}/api-browser`).normalizePathname();

I think we could add a component that unifies both usages, I leave it up to you.

@bernd bernd self-assigned this Aug 3, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 3, 2016

LGTM 👍

@bernd bernd merged commit 981ef53 into master Aug 3, 2016

0 of 4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1214 is running
Details
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bernd bernd deleted the revert-pr-2361 branch Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment