Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorator improvements #2654

Merged
merged 14 commits into from
Aug 10, 2016
Merged

Decorator improvements #2654

merged 14 commits into from
Aug 10, 2016

Commits on Aug 10, 2016

  1. Fix decorator list styling 

    Fixes #2598
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    062291c View commit details
    Browse the repository at this point in the history

  2. Move decorators help to popover 

    In that way we gain some additional spacing on the sidebar.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    b079a42 View commit details
    Browse the repository at this point in the history

  3. Improve add decorator styling 

    Clean-up divs and improve margins
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    a2b75d1 View commit details
    Browse the repository at this point in the history

  4. Move edit and delete buttons into actions dropdown 

    The decorator list doesn't have much space, and this makes it look
cleaner.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    c023129 View commit details
    Browse the repository at this point in the history

  5. Do not add pipeline decorator without a pipeline 

    Mark non-optional select values as required, avoiding submitting a form
to create a pipeline decorator without selecting a pipeline.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    17f5e0d View commit details
    Browse the repository at this point in the history

  6. Remove unused imports

    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    d826989 View commit details
    Browse the repository at this point in the history

  7. Relax prop type in sortable list 

    Message decorators pass react elements instead of text, but that should
be allowed.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    f675391 View commit details
    Browse the repository at this point in the history

  8. Fix message fields separation

    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    daee309 View commit details
    Browse the repository at this point in the history

  9. Only show "show original" message button when decorated

    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    f8b793f View commit details
    Browse the repository at this point in the history

  10. Do not display message field actions when decorated 

    Before this change, we didn't display message field actions for fields
added by a message decorator, but we did when a field was altered by a
decorator. This changes that behaviour, as decorated values will not
work on searches, and cannot be extracted.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    9b5ef22 View commit details
    Browse the repository at this point in the history

  11. Add modified fields to search decoration stats 

    We should also include changed and modified fields. And also show the
actual added fields.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    af54931 View commit details
    Browse the repository at this point in the history

  12. Do not show field analyzers for decorated fields 

    Fields added by decorators did not show field analyzers, but modified
fields did. This removes that, as it won't work.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    eb20339 View commit details
    Browse the repository at this point in the history

  13. Guard against null DecorationStats

    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    e2a0a38 View commit details
    Browse the repository at this point in the history

  14. Use a more explicit indicator for decorated fields 

    Replace the pencil icon with some text that self explains why that field
is special.
    Edmundo Alvarez committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    d843a43 View commit details
    Browse the repository at this point in the history