Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify actions in search page triggering a page reload #2798

Merged
merged 8 commits into from Sep 9, 2016
Merged

Commits on Sep 7, 2016

  1. Avoid page reload when a search param changes

    When changing the search page or histogram resolution, do not force a
    full page reload, but change the URL. That triggers an update of the
    stores involved in the search.
    
    Refs #2488
    Edmundo Alvarez committed Sep 7, 2016
    Copy the full SHA
    b7d1f53 View commit details
    Browse the repository at this point in the history
  2. Avoid page reload on search submit

    Prevent the submit of new searches, and change the URL instead. That
    triggers an update on the stores involved in the search page.
    
    Refs #2488
    Edmundo Alvarez committed Sep 7, 2016
    Copy the full SHA
    1f73910 View commit details
    Browse the repository at this point in the history
  3. Use latest search to get widget parameters

    Delay fetching search parameters to create widgets until the last
    moment, so we ensure the parameters used are the ones from the latest
    search performed.
    Edmundo Alvarez committed Sep 7, 2016
    Copy the full SHA
    b4776a0 View commit details
    Browse the repository at this point in the history
  4. Avoid page reload when loading saved search

    Instead replace URL and let search stores to fetch new data.
    
    Refs #2488
    Edmundo Alvarez committed Sep 7, 2016
    Copy the full SHA
    6b54690 View commit details
    Browse the repository at this point in the history
  5. Fix search page sorting

    After the last changes in the search reload behaviour, remove the
    `sortField` and `sortOrder` options from `SearchResult`'s state and rely
    on `SearchStore` to provide the right values.
    Edmundo Alvarez committed Sep 7, 2016
    Copy the full SHA
    b315b9c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. Add search loading indicator

    Since we don't reload the search page now, we need a way of giving
    feedback to the user when the search is being loaded. This commit
    introduces a loading indicator in the bottom right corner of the screen
    for such purpose.
    Edmundo Alvarez committed Sep 8, 2016
    Copy the full SHA
    6e974b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2016

  1. Remove unused openLink method

    Edmundo Alvarez committed Sep 9, 2016
    Copy the full SHA
    6a50c01 View commit details
    Browse the repository at this point in the history
  2. Make search loading indicator reusable

    Edmundo Alvarez committed Sep 9, 2016
    Copy the full SHA
    0bc22e0 View commit details
    Browse the repository at this point in the history