-
Notifications
You must be signed in to change notification settings - Fork 1.1k
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app reloads on search #2488
Comments
We are facing the same problems since 2.0.3. Environment Graylog Version: 2.0.3 (f07c170), codename Rothaus When it's helpful i could provide you with our timeline-log. |
Hi @gruselglatz, I wonder if there is some issue in your setup when loading the page takes more than 10 seconds. Did you check where the time is being used? |
I used the Chrome TimelineTool and i could share it with you, if it would be helpful. I'm not a Webdeveloper, so i can't read much out of it. |
@gruselglatz That would be great. I'm not sure how helpful it would be, but at least I can take a look and see if I can extract something from it. Thank you! |
@edmundoa I've sent it to you via Email. I hope you could see something. |
@gruselglatz email received, thank you! |
UDAPTE: After i dismissed the "First Start Help" the Search now loads in half the time: 4-6 seconds.
UPDATE 2: I don't know why the enterprise, collector and map plugin always gets loaded and executed, so i moved the plugins out, and i save additional 3 seconds of loading time.... |
Can you see what takes so long? Connection buildup, downloading JS, interpreting, running? |
@dennisoelkers i have sent three of my timeline logs to @edmundoa maybe he could send it to you for further investigations. I've listed the names of the scripts that were on top of the "fire-graph", where i can see what time is used for Connection buildup, downloading JS, interpreting, running? EDIT: is this what you want?
|
@hc4 i can confirm that on 2.0.3 also. It seems when you hit only the "Search"-tab none of the exhausting functions get called. only the "PiplineProcessorPlugin"-function. So after the Mouse-Click-Event it takes 336ms for scripts to run and 1,9ms for rendering the new messages. Compare that to the other values above. |
That is an expected behaviour since 2.0.x, @hc4 and @gruselglatz. The reason for this is mostly legacy now, but we still need to do some clean up to use the new search stores to fetch data instead of submitting the form as it was done in previous versions. |
When changing the search page or histogram resolution, do not force a full page reload, but change the URL. That triggers an update of the stores involved in the search. Refs #2488
Prevent the submit of new searches, and change the URL instead. That triggers an update on the stores involved in the search page. Refs #2488
Instead replace URL and let search stores to fetch new data. Refs #2488
* Avoid page reload when a search param changes When changing the search page or histogram resolution, do not force a full page reload, but change the URL. That triggers an update of the stores involved in the search. Refs #2488 * Avoid page reload on search submit Prevent the submit of new searches, and change the URL instead. That triggers an update on the stores involved in the search page. Refs #2488 * Use latest search to get widget parameters Delay fetching search parameters to create widgets until the last moment, so we ensure the parameters used are the ones from the latest search performed. * Avoid page reload when loading saved search Instead replace URL and let search stores to fetch new data. Refs #2488 * Fix search page sorting After the last changes in the search reload behaviour, remove the `sortField` and `sortOrder` options from `SearchResult`'s state and rely on `SearchStore` to provide the right values. * Add search loading indicator Since we don't reload the search page now, we need a way of giving feedback to the user when the search is being loaded. This commit introduces a loading indicator in the bottom right corner of the screen for such purpose. * Remove unused openLink method * Make search loading indicator reusable
* Avoid page reload when a search param changes When changing the search page or histogram resolution, do not force a full page reload, but change the URL. That triggers an update of the stores involved in the search. Refs #2488 * Avoid page reload on search submit Prevent the submit of new searches, and change the URL instead. That triggers an update on the stores involved in the search page. Refs #2488 * Use latest search to get widget parameters Delay fetching search parameters to create widgets until the last moment, so we ensure the parameters used are the ones from the latest search performed. * Avoid page reload when loading saved search Instead replace URL and let search stores to fetch new data. Refs #2488 * Fix search page sorting After the last changes in the search reload behaviour, remove the `sortField` and `sortOrder` options from `SearchResult`'s state and rely on `SearchStore` to provide the right values. * Add search loading indicator Since we don't reload the search page now, we need a way of giving feedback to the user when the search is being loaded. This commit introduces a loading indicator in the bottom right corner of the screen for such purpose. * Remove unused openLink method * Make search loading indicator reusable (cherry picked from commit f51e5ca)
This has been fixed in #2798 and will be included in the upcoming 2.1.1 release. |
Problem description
app reloads when you click search
Steps to reproduce the problem
Environment
The text was updated successfully, but these errors were encountered: