Make ValidatorProvider a Singleton #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Validator instance creation is quite expensive. Making this a Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs per second to 2 GCs per second when running a load test of the collector registration endpoint.
joschi
reviewed
Sep 20, 2016
| @@ -24,6 +24,6 @@ | |||
| public class ValidatorModule extends AbstractModule { | |||
| @Override | |||
| protected void configure() { | |||
| bind(Validator.class).toProvider(ValidatorProvider.class); | |||
| bind(Validator.class).toProvider(ValidatorProvider.class).asEagerSingleton(); | |||
There was a problem hiding this comment.
It would be simpler to directly bind to the instance Validation.buildDefaultValidatorFactory().getValidator() instead of using a singleton provider which basically returns a static field. This way we could get rid of the Provider<Validator>.
There was a problem hiding this comment.
Good point, will change that.
|
Updated after review comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Validator instance creation is quite expensive. Making this a Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs per second to 2 GCs per second when running a load test of the collector registration endpoint.
Before
After