Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fetching/checking unnecessary streams in AlertScannerThread. #3336

Merged
merged 3 commits into from Jan 11, 2017

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 11, 2017

Description

Motivation and Context

With this change, StreamService#loadAllWithConfiguredAlertConditions does not fetch streams without configured alert conditions, therefore AlertScannerThread does not check streams unnecessarily.

How Has This Been Tested?

Added fixtures and unit tests for StreamServiceImpl.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
With this change, StreamService#loadAllWithConfiguredAlertConditions
does not fetch streams without configured alert conditions, therefore
AlertScannerThread does not check streams unnecessarily.
@kroepke kroepke self-requested a review Jan 11, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm

@kroepke kroepke merged commit 66d835a into master Jan 11, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1261 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the prevent-unnecessary-stream-fetches-in-alert-scanner branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants