Revert "Prevent useless session validation when no id or username is present. (#3634)" #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
approved these changes
Jul 4, 2017
dennisoelkers
added a commit
that referenced
this pull request
Jul 28, 2017
Before this change, whenever a session validation attempt failed, the session data in localStorage was removed. This was leading to a race condition for automated browser testing, when validation took longer than visiting the page for the first time to put session data in localStorage, which was immediately removed by the validation promise handler. After this change, session data in localStorage is removed only if present. Refs #3634, #3948, #3973.
9 tasks
bernd
pushed a commit
that referenced
this pull request
Jul 28, 2017
Before this change, whenever a session validation attempt failed, the session data in localStorage was removed. This was leading to a race condition for automated browser testing, when validation took longer than visiting the page for the first time to put session data in localStorage, which was immediately removed by the validation promise handler. After this change, session data in localStorage is removed only if present. Refs #3634, #3948, #3973.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c3983db.
The SSO plugin relies on validation of the session to be able to skip the login form and log in the user automatically.
Fixes #3948