Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove navigation warnings #4192

Merged
merged 5 commits into from
Oct 2, 2017
Merged

Remove navigation warnings #4192

merged 5 commits into from
Oct 2, 2017

Commits on Sep 29, 2017

  1. Fix react-unknown-prop on brand link 

    Filter out `active` prop on logo link.
    Edmundo Alvarez committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    c05d175 View commit details
    Browse the repository at this point in the history

  2. Remove eventKey from Navbar.Collapse 

    This is not needed and triggers a warning, as it is passed down to the
div doing the collapse.
    Edmundo Alvarez committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    4ef3d13 View commit details
    Browse the repository at this point in the history

  3. Use consistent indentation

    Edmundo Alvarez committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    0295c88 View commit details
    Browse the repository at this point in the history

  4. Fix another react-unknown-prop warning 

    Replace hack to remove active MenuItem state with a custom component.
This makes more clear what we want to achieve and removes the warning
from the console.
    Edmundo Alvarez committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    7630e10 View commit details
    Browse the repository at this point in the history

  5. Use react-bootstrap's Badge in navigation bar 

    Replacing the custom `span` tags with `Badge` also removes a warning
from the web console.

We also remove the inline styles with a Badge.css file, which allows us
to apply different appearances to badges. This is not supported by
react-bootstrap or bootstrap out of the box.
    Edmundo Alvarez committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    5ee6849 View commit details
    Browse the repository at this point in the history