Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only display dashboards with write permissions in add to dashboard me… #4511

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

kmerz
Copy link
Member

@kmerz kmerz commented Jan 24, 2018

…nu (#4505)

  • Add tests for issue

  • Only display dashboards with write access in menu

  • Update current user permissions with the initial state

  • Make writableDashboards consistent with dashboards

This store is using ImmutableJS to store the dashboards state, and it
should do the same with the writableDashboards

  • Fix eslint errors on test

…nu (#4505)

* Add tests for issue

* Only display dashboards with write access in menu

* Update current user permissions with the initial state

* Make writableDashboards consistent with dashboards

This store is using ImmutableJS to store the dashboards state, and it
should do the same with the writableDashboards

* Fix eslint errors on test
@kmerz kmerz added this to the 2.4.2 milestone Jan 24, 2018
@ghost ghost assigned kmerz Jan 24, 2018
@ghost ghost added the in progress label Jan 24, 2018
Copy link
Contributor

@edmundoa edmundoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for backporting it!

@edmundoa edmundoa merged commit b029269 into 2.4 Jan 24, 2018
@edmundoa edmundoa deleted the issue-4504-2.4 branch January 24, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants