Add test button to alert conditions #5316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd
requested changes
Nov 28, 2018
graylog2-web-interface/src/components/alertconditions/AlertConditionTestModal.jsx
Show resolved
Hide resolved
added 2 commits
November 28, 2018 19:04
To help users easily see whether a condition would trigger the alert or not, add a small icon that gives a visual hint to what would happen.
bernd
pushed a commit
that referenced
this pull request
Nov 28, 2018
* Add test button to alert conditions * Add icon to easily see when alert would trigger To help users easily see whether a condition would trigger the alert or not, add a small icon that gives a visual hint to what would happen. * Change dropdown menu text for consistency (cherry picked from commit 2874b99)
bernd
added a commit
that referenced
this pull request
Nov 28, 2018
* Add test button to alert conditions * Add icon to easily see when alert would trigger To help users easily see whether a condition would trigger the alert or not, add a small icon that gives a visual hint to what would happen. * Change dropdown menu text for consistency (cherry picked from commit 2874b99)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last changes in the alerting API introduced an endpoint to test alert conditions. This PR adds UI for it, so users can test if a certain alert condition would trigger an alert or not at that point of time.
This needs to be cherry-picked into 2.5.