-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GracefulShutdownService #5738
Merged
Merged
Commits on Feb 28, 2019
-
Services can register themselves with the GracefulShutdownService to make sure they will be stopped gracefully on server shutdown. This allows plugins to participate in a graceful server shutdown to make sure the server is not terminated before the plugin shutdown routine is done.
Configuration menu - View commit details
-
Copy full SHA for be5746b - Browse repository at this point
Copy the full SHA be5746bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b4d256 - Browse repository at this point
Copy the full SHA 5b4d256View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a54aa8 - Browse repository at this point
Copy the full SHA 1a54aa8View commit details
Commits on Mar 1, 2019
-
Don't allow register/unregister when the shutdown is running
Once the shutdown has started, we cannot modify the set of hooks because that might to race conditions and a hanging shutdown. Objects that try to register/unregister during the shutdown phase will get an IllegalStateException that should be handled.
Configuration menu - View commit details
-
Copy full SHA for d81466c - Browse repository at this point
Copy the full SHA d81466cView commit details -
Make graceful shutdown logging more verbose
This will make it easier for users to debug a hanging shutdown process.
Configuration menu - View commit details
-
Copy full SHA for 0cff931 - Browse repository at this point
Copy the full SHA 0cff931View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8dc84c - Browse repository at this point
Copy the full SHA d8dc84cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1013655 - Browse repository at this point
Copy the full SHA 1013655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14d6865 - Browse repository at this point
Copy the full SHA 14d6865View commit details -
Fix race condition in failRegisterAndUnregisterDuringShutdown test
We don't really need a blocking latch in the hook because we can also check the behavior after the service is terminated.
Configuration menu - View commit details
-
Copy full SHA for b78be52 - Browse repository at this point
Copy the full SHA b78be52View commit details -
No need to wait for the termination of the executor
The latch is open at this point and all shutdown hooks have been executed.
Configuration menu - View commit details
-
Copy full SHA for 779006e - Browse repository at this point
Copy the full SHA 779006eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.