Prevent double prefixing paths for navigation items in system menu. #5765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is backporting #5703 to `3.0`. In #5193, the newly created `NavigationLink` component performs prefixing the path passed to it with the application prefix. This is happening although in `Routes.jsx` all routes are already being prefixed before being exported. This change is removing the prefixing in `NavigationLink`. Fixes #5702. (cherry picked from commit bcf53ec)
kmerz
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is backporting #5703 to
3.0.In #5193, the newly created
NavigationLinkcomponent performsprefixing the path passed to it with the application prefix. This is
happening although in
Routes.jsxall routes are already being prefixedbefore being exported.
This change is removing the prefixing in
NavigationLink.Fixes #5702.
(cherry picked from commit bcf53ec)
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: