Fix missing guice bindings for MessageOutput.Factory2 #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to call the outputsMapBinder2() method during startup to always create the map binder for MessageOutput.Factory2. Otherwise the server doesn't start when there is no output that is using the factory.
danotorrey
approved these changes
Mar 13, 2019
bernd
added a commit
that referenced
this pull request
Apr 1, 2019
We have to call the outputsMapBinder2() method during startup to always create the map binder for MessageOutput.Factory2. Otherwise the server doesn't start when there is no output that is using the factory. (cherry picked from commit 7ab91b0)
bernd
added a commit
that referenced
this pull request
Apr 1, 2019
We have to call the outputsMapBinder2() method during startup to always create the map binder for MessageOutput.Factory2. Otherwise the server doesn't start when there is no output that is using the factory. (cherry picked from commit 7ab91b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to call the outputsMapBinder2() method during startup to always
create the map binder for MessageOutput.Factory2. Otherwise the server
doesn't start when there is no output that is using the factory.
This is fallout from #5670.