Consider current dashboard query filter and defined parameters when using message list pagination #7683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide current parameter bindings when using message list pagination
linuspahl
changed the title
kmerz
approved these changes
Mar 16, 2020
kmerz
pushed a commit
that referenced
this pull request
Mar 16, 2020
…sing message list pagination (#7683) * Always provide current parameter bindings when reexecuting searchtypes * provide current parameter bindings when using message list pagination * Remove only in MessageList test * Remove not needed mock * Sort message list prop type definitions * Consider global override query in search re-execution * Fix linting * Use current execution state directly from SearchStore
9 tasks
linuspahl
added a commit
that referenced
this pull request
Mar 17, 2020
…sing message list pagination (#7693) * Consider current dashboard query filter and defined parameters when using message list pagination (#7683) * Always provide current parameter bindings when reexecuting searchtypes * provide current parameter bindings when using message list pagination * Remove only in MessageList test * Remove not needed mock * Sort message list prop type definitions * Consider global override query in search re-execution * Fix linting * Use current execution state directly from SearchStore * Use object import for URLUtils, since qualifyURL is not exported in 3.2 Co-authored-by: Linus Pahl <46300478+linuspahl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Needs a backport to
3.2.As described in #7680 a message list widget with an own search query does not consider the dashboard search query filter when using the widget pagination.
With this PR we are considering the dashboard filter search query on every search re-execution. A search re-execution currently only happens when using the message list pagination.
Fixes #7680
And also fixes #7665
Types of changes
Checklist: