Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider current dashboard query filter and defined parameters when using message list pagination #7693

Merged
merged 2 commits into from Mar 17, 2020
Merged

Consider current dashboard query filter and defined parameters when using message list pagination #7693

merged 2 commits into from Mar 17, 2020

Conversation

kmerz
Copy link
Member

@kmerz kmerz commented Mar 16, 2020 •
edited by linuspahl

Backport of #7683 for 3.2

As described in #7680 a message list widget with an own search query does not consider the dashboard search query filter when using the widget pagination.

With this PR we are considering the dashboard filter search query on every search re-execution. A search re-execution currently only happens when using the message list pagination.

Fixes #7680
And also fixes #7665

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kmerz kmerz requested a review from linuspahl March 16, 2020 15:18
@kmerz kmerz changed the base branch from master to 3.2 March 16, 2020 15:18
@linuspahl @kmerz
Consider current dashboard query filter and defined parameters when u…
97e683d 
…sing message list pagination (#7683)

* Always provide current parameter bindings when reexecuting searchtypes

* provide current parameter bindings when using message list pagination

* Remove only in MessageList test

* Remove not needed mock

* Sort message list prop type definitions

* Consider global override query in search re-execution

* Fix linting

* Use current execution state directly from SearchStore
@linuspahl linuspahl added this to the 3.2.4 milestone Mar 17, 2020
linuspahl
linuspahl approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@linuspahl linuspahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with 3.2

@linuspahl linuspahl merged commit ef61c33 into 3.2 Mar 17, 2020
@linuspahl linuspahl deleted the issue-7665-3.2 branch March 17, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuspahl linuspahl linuspahl approved these changes

Assignees
No one assigned
Labels
backport ready-for-review search
Projects
None yet
Milestone
3.2.4
2 participants
@kmerz @linuspahl