-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pipeline): transform support on_failure #4123
Conversation
chore: merge main
refactor: use `inserter` instead of `grpc_handler` in pipeline operator
on_failure
on_failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4123 +/- ##
==========================================
- Coverage 84.94% 84.89% -0.06%
==========================================
Files 1018 1022 +4
Lines 178688 179152 +464
==========================================
+ Hits 151780 152083 +303
- Misses 26908 27069 +161 |
Wait for #4014 get merged first, then we can add some test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job!
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
when transform failed, the
on_failure
will try to prevent the failure ot ETL. And the valid value for on_failure is:default
orignore
.The following will set the
number
field to default (which is 0 in the yaml) if its value can not be coerced to int32Checklist