Build the functional part as a shared library

[massix]

Hello, I'd like to develop a GUI using your code as a solid base. Indeed, the base is so solid that I'd like to use it as a shared library.

As you might see by this pull request, I've converted your CMakeLists file to build the shared library using the three main components (drive, transport and utils) and build the "grive" binary (renamed grive_cli) linking it against the library.

It works like a charm and I thought this might be interesting for you. Feel free to ignore this PR if you're not interested in developing a shared library.

[match065]

I like the idea of using a shared library. It will be useful for the unit test also.

But I don't want to call the main executable "grive_cli". I want to keep it as "grive". Can the library and the executable use the same name?

[massix]

Hi, as far as I know it's not possible to define two targets with the same name in CMake :(

If you want, we can use a different name for the library (libfgrive? Functional Grive..) and then use "grive" for the binary.. it's up to you :)

[match065]

OK. That's good.

I just merged another change on the cmakefile with a number of improvement. Would you please merge that first?

Many thanks!!

[massix]

Salut, the last commit should do the trick.. I've renamed the library into "fgrive" and left the binary to "grive".

The headers are installed in $(CMAKE_PREFIX_DIR)/include/grive/{drive,protocol,utils}

pearl :: Developer/grive/build » make install [ 66%] Built target fgrive [ 73%] Built target grive [100%] Built target unittest Install the project... -- Install configuration: "" -- Installing: /usr/local/lib/libfgrive.0.0.1.dylib -- Up-to-date: /usr/local/lib/libfgrive.0.dylib -- Up-to-date: /usr/local/lib/libfgrive.dylib -- Installing: /usr/local/bin/grive -- Up-to-date: /usr/local/include/grive/drive/Collection.hh -- Up-to-date: /usr/local/include/grive/drive/Drive.hh -- Up-to-date: /usr/local/include/grive/protocol/Download.hh -- Up-to-date: /usr/local/include/grive/protocol/HTTP.hh -- Up-to-date: /usr/local/include/grive/protocol/Json.hh -- Up-to-date: /usr/local/include/grive/protocol/OAuth2.hh -- Up-to-date: /usr/local/include/grive/util/Crypt.hh -- Up-to-date: /usr/local/include/grive/util/DateTime.hh -- Up-to-date: /usr/local/include/grive/util/Function.hh -- Up-to-date: /usr/local/include/grive/util/OS.hh

[match065]

I prefer the name grivelib. Is this OK with you?

[massix]

It's just a matter of taste, grivelib then becomes libgrivelib (which is quite redundant if you ask me :-P) but since this is your project, just do whatever you think it's better :P

[match065]

This is our project. I am keeping libfgrive then.

[massix]

Yep, it's probably better.. anyway the name isn't that important, we can change it in the future.. just keep this one until we don't come up with a better idea ;-)

[sgbeal]

FWIW, i rather like the name grive/libgrive.

[match065]

Me too. Can you get it work in cmake?

[massix]

I'm working on it actually.. I've probably found a workaround..

[match065]

Thanks massix! Look forward to your pull request.