-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change importing in tests on filesObjects #282
Comments
It appears that the first github link is not working. |
try again, it's about formatting links here |
That worked |
To make sure I'm understanding this right my job is to go through the tests and in for example cup1.test.js file change const {cup1} = require('../../../files.js') to const staticData = require("./filesObjects") |
i'm not Vadim, so cannot reply to you exactly. Make your changes, show you code and when we will be ready - he will tell you if you need to change something in your code ;) |
Btw, some our other developer, Ebrahim also show interest to make some changes in tests - so be aware about it - because your changes can generate a conflict with his code |
did we finish this task? |
@Edebo can you grab this task too? |
it's done |
Tests for this task you can find here https://github.com/GroceriStar/sd/tree/master/src/data/__tests__/
In this file tests
For example in https://github.com/GroceriStar/sd/blob/master/src/data/__tests__/cup1.test.js#L3
is import from files.js. Replace this importing by importing from filesObjects.js that is in root of project.
To import from filesObjects.js you need to use this import
staticData
contains data of all files that is stored in src/data. staticData is array that contains all objects. Object contains property name - filename, value - object that was got from file.staticData.allergies returns object.
allergies
is a value of property allergiesThe text was updated successfully, but these errors were encountered: