-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gallery fix #162
gallery fix #162
Conversation
<a href="{{croppaUrl($image->uploadPath())}}" class="colorbox thumbnail" | ||
rel="gallery" title="{{($image->title($language->code))? $image->title($language->code) : ''}}"> | ||
<img class="img-fluid" | ||
title="{{($image->title($language->code))? $image->title($language->code) : ''}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to check if title exists, view model does it for you and it will return null if title is not available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
# Conflicts: # tests/unit/jobs/ContentJobsTest.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
No description provided.