-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GtkSharp net6 workload #351
feat: GtkSharp net6 workload #351
Conversation
A question about templates: |
i would prefer separate workload template pack |
Done. I've added the workload packs for the three languages.
|
And also changed the build script to target SDK bands.
aa5a4af
to
c80ce6b
Compare
We had some testing of the .NET 6 workload at #maui-linux:matrix.org and it proved ok to use, although there seems to be an issue with the templates on Linux that is still under investigation. This is how you would test it (including a hack to make the templates appear) on Ubuntu 22.04:
Having this included in an official release would be useful for our effort to establish Linux support for .NET MAUI (Multi-platform App UI). |
Well, I'm low on time, so its time to merge first and ask questions later :D Thanks @trungnt2910 ! |
@harry-cpp AFAIU, there's no version in nuget that has the feature yet. Why hasn't there been a release recently? |
You might want to upvote #355. |
A .NET 6 Workload for GtkSharp. Should close #349.
What it can do:
Allow projects like this:
to build, run and publish correctly, with a unique
net6.0-gtk
TFM and no package references.Some changes I made:
CreateFrameworkListFile
target fromMicrosoft.DotNet.SharedFramework.Sdk
, used to generate reference and runtime library packs, requires input assemblies to be signed, as it checks for a non-nullPublicKeyToken
. Furthermore, other .NET workload packs I know (Tizen, Xamarin,...) also have strong names.Directory.Build.props
file, so that the workloads and the libraries can share a few build variables. This makes it easier for workload build scripts to locate output libraries for frameworks.I hope this pull request can be considered. If there's anything in this PR against the project's rules, please let me know as soon as possible so that I can quickly fix the problem.