Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTK] Upgrade to GtkSharp 3.24.24.95 #2520

Closed
cyanfish opened this issue Jul 14, 2023 · 6 comments · Fixed by #2584
Closed

[GTK] Upgrade to GtkSharp 3.24.24.95 #2520

cyanfish opened this issue Jul 14, 2023 · 6 comments · Fixed by #2584
Milestone

Comments

@cyanfish
Copy link
Contributor

Can the GtkSharp dependency be to the latest version (3.24.24.95) when feasible? It includes the fix to GtkSharp/GtkSharp#393 (file choosers not working on linux-arm64) and I'm sure other issues as well.

@cwensley
Copy link
Member

Yes absolutely... but also be aware that you can use the latest version of GtkSharp just by adding the package reference to your project explicitly.

@cwensley cwensley added this to the 2.8.x milestone Jul 14, 2023
@cyanfish
Copy link
Contributor Author

Yeah, that works fine just using common Eto classes. Unfortunately referencing classes from Eto.Platform.Gtk gives errors like this:
The type 'Pixbuf' is defined in an assembly that is not referenced. You must add a reference to assembly 'GdkSharp, Version=3.24.24.34, Culture=neutral, PublicKeyToken=null'.

There might be some way to fix it, and the cause is probably something to do with the GtkSharp build, but certainly changing it at the Eto level should resolve it.

@cwensley
Copy link
Member

Interesting, that shouldn't be the case. It looks like GtkSharp re-added strong naming (it was previously attempted in 2020 which resulted in #1761) which breaks all compatibility when compiled with previous versions.

@cwensley
Copy link
Member

@harry-cpp if strong naming is staying this time I'll update Eto's references and work on updating all the other controls. Any other existing assemblies will need to be recompiled for the new version.

@cyanfish
Copy link
Contributor Author

For reference strong naming was added in GtkSharp/GtkSharp#351

@harry-cpp
Copy link
Contributor

Yea, it got added because peeps wanted a gtk workload for gtk version of maui, its staying on this time.

cyanfish added a commit to cyanfish/Eto that referenced this issue Nov 25, 2023
@cwensley cwensley modified the milestones: 2.8.x, 2.8.3 Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants