Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 20 support #294

Closed
dougxc opened this issue Nov 9, 2022 · 8 comments
Closed

JDK 20 support #294

dougxc opened this issue Nov 9, 2022 · 8 comments
Labels

Comments

@dougxc
Copy link

dougxc commented Nov 9, 2022

JDK 20 is going to land in March 2023. It would be great to have JDK 20 support in ProGuard soon to be prepared.

@mrjameshamilton
Copy link
Collaborator

Looking at the JDK 20 page there doesn't seem to be anything that requires major changes in ProGuard, except for a version bump.

@dougxc
Copy link
Author

dougxc commented Jan 18, 2023

Hi @mrjameshamilton , is there a rough ETA as to when there will be a release with support for JDK 20?

@mrjameshamilton
Copy link
Collaborator

Hi @dougxc ! Since there doesn't seem to be any relevant changes required apart from the version bump; I've bumped the max supported version in ProGuardCORE.

To already test it you could build ProGuardCORE + ProGuard yourself:

  • Publish ProGuardCORE to mavenLocal: ./gradlew publishToMavenLocal
  • Update the ProGuardCORE version in the ProGuard gradle.properties file
  • Build ProGuard: ./gradlew assemble

I also attach a pre-built zip distribution: proguard-7.3.2.zip

@dougxc
Copy link
Author

dougxc commented Jan 30, 2023

I've run our tests with that pre-built zip and everything works - thanks! Hopefully this means a release with these changes can be made soon.

@dougxc
Copy link
Author

dougxc commented Feb 17, 2023

@mrjameshamilton is there any chance a release could be made soon?

@mrjameshamilton
Copy link
Collaborator

Hi @dougxc ! I'll try to make a release next week.

@dougxc dougxc closed this as completed Mar 3, 2023
@dougxc dougxc reopened this Mar 3, 2023
@dougxc
Copy link
Author

dougxc commented Mar 3, 2023

Sorry - accidental press of the wrong button!

@mrjameshamilton
Copy link
Collaborator

Released in 7.3.2 https://github.com/Guardsquare/proguard/releases/tag/v7.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants