Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CrispyWaffle from 7.0.18 to 7.0.83 #323

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 22, 2024

Bumps CrispyWaffle from 7.0.18 to 7.0.83.

Release notes

Sourced from CrispyWaffle's releases.

v7.0.83

Release of CrispyWaffle - v7.0.83

v7.0.75

Release of CrispyWaffle - v7.0.75

v7.0.39

Release of CrispyWaffle - v7.0.39

Commits
  • b919adc docs(contributor): contrib-readme-action has updated readme (#459)
  • f0a393d Update changelog.md (#458)
  • a7d2af4 Update README.md (#457)
  • 4dbe209 docs(contributor): contrib-readme-action has updated readme (#456)
  • c2dbb19 docs(contributor): contrib-readme-action has updated readme (#455)
  • 40c5716 Fix GH Action (#454)
  • 94efea4 docs(contributor): contrib-readme-action has updated readme (#452)
  • 977ff6d docs(contributor): contrib-readme-action has updated readme (#453)
  • 6ce9c6a Update contributors-readme.yml
  • d4792d7 Fix contributing section of readme files (#450)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Description by Korbit AI

Note

This feature is in early access. You can enable or disable it in the Korbit Console.

Bump CrispyWaffle from 7.0.18 to 7.0.83

This PR updates the CrispyWaffle library from version 7.0.18 to 7.0.83 across the project configuration files.

Why are these changes being made?

The update addresses compatibility issues and includes performance improvements and bug fixes provided in the newer version of CrispyWaffle. This ensures that the project benefits from the latest features and stability enhancements.

Bumps [CrispyWaffle](https://github.com/guibranco/CrispyWaffle) from 7.0.18 to 7.0.83.
- [Release notes](https://github.com/guibranco/CrispyWaffle/releases)
- [Changelog](https://github.com/guibranco/CrispyWaffle/blob/main/docs/changelog.md)
- [Commits](guibranco/CrispyWaffle@v7.0.18...v7.0.83)

---
updated-dependencies:
- dependency-name: CrispyWaffle
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies nuget NuGet package labels Jul 22, 2024
@dependabot dependabot bot requested a review from guibranco July 22, 2024 11:41
Copy link

semanticdiff-com bot commented Jul 22, 2024

Review changes with SemanticDiff.

Analyzed 1 of 5 files.

Filename Status
Src/GHActionsCI/App.config Unsupported file format
Src/GHActionsCI/GHActionsCI.csproj Unsupported file format
Src/GHActionsCI/packages.config Unsupported file format
✔️ Src/GHActionsCI/Properties/AssemblyInfo.cs Analyzed
Src/GHActionsCI/Properties/Version.txt Unsupported file format

Copy link

korbit-ai bot commented Jul 22, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

coderabbitai bot commented Jul 22, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

pr-code-reviewer bot commented Jul 22, 2024

👋 Hi there!

  1. Ensure consistent formatting and indentation for readability.
  2. Verify that version ranges in binding redirects are correctly updated.
  3. Confirm that new dependency entries like "CrispyWaffle" follow the established naming and token conventions.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at webber@takken.io.

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

gooroo-dev bot commented Jul 22, 2024

There are no known files to review.

Currently, I support these languages:

  • Ada: .adb, .ads
  • Assembly: .asm, .s
  • C: .c, .h
  • C++: .cpp, .hpp, .hxx, .cc, .cxx
  • C#: .cs
  • Clojure: .clj, .cljs, .cljc
  • COBOL: .cob, .cbl
  • Dart: .dart
  • Elixir: .ex, .exs
  • Erlang: .erl, .hrl
  • F#: .fs, .fsi, .fsx
  • Fortran: .f, .f90, .f95, .f03, .f08
  • Go: .go
  • Groovy: .groovy, .gvy, .gy, .gsh
  • Haskell: .hs, .lhs
  • Java: .java, .jav
  • JavaScript: .js, .jsx, .ts, .tsx, .coffee, .flow, .gs
  • Julia: .jl
  • Kotlin: .kt, .kts
  • Lua: .lua
  • MATLAB: .m, .mat
  • Markup Languages: .md, .markdown, .yaml, .yml, .json
  • Objective-C: .m, .mm
  • Pascal: .pas, .pp
  • PHP: .php, .phtml, .php3, .php4, .php5, .phps, .phpt
  • Perl: .pl, .pm
  • Python: .py
  • R: .r, .rdata, .rds
  • Ruby: .rb, .erb, .haml, .slim
  • Rust: .rs
  • Scala: .scala, .sc
  • Shell Scripting: .sh, .bash, .ps1, .bat, .cmd
  • SQL: .sql
  • Swift: .swift
  • TOML: .toml
  • TypeScript: .ts, .tsx
  • VHDL: .vhdl, .vhd
  • Verilog: .v, .vh
  • HTML: .html, .htm
  • CSS: .css, .sass, .scss
  • XML: .xml, .xsd, .xsl, .xslt

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. App.config and GHActionsCI.csproj: The version number for the CrispyWaffle assembly in App.config and GHActionsCI.csproj seems to be inconsistent. It should be synchronized to avoid potential dependency conflicts.

  2. App.config: The assemblyIdentity element with the name CrispyWaffle has a publicKeyToken set to "null". Ensure this value is correctly specified to match the assembly's actual public key token.

  3. App.config: In the dependentAssembly element for assembly System.Security.AccessControl, the newVersion is set to 6.0.0.1. This version should be verified as it might not align with the actual available version numbers for System.Security.AccessControl assembly.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. GHActionsCI.csproj: For consistency and clarity, ensure that all references to assemblies and their versions across different project files are updated simultaneously to maintain coherence in the project structure.

  2. App.config: Consider grouping the <dependentAssembly> elements alphabetically based on the name attribute to enhance readability and maintainability of the configuration file.

  3. packages.config: Similar to other files, maintain consistency by ensuring that the version number for CrispyWaffle in the packages.config file is also updated to 7.0.83 wherever necessary.

Copy link

instapr bot commented Jul 22, 2024

Feedback:

Great job on bumping CrispyWaffle to version 7.0.83! The changes look good overall.

Just one minor improvement suggestion:

  • In Src/GHActionsCI/App.config, consider updating the bindingRedirect range for CrispyWaffle to be more specific.

Keep up the good work! 👍

@guibranco guibranco enabled auto-merge (squash) July 22, 2024 11:42
@gstraccini gstraccini bot added the ☑️ auto-merge Auto-merge enabled by gstraccini-bot label Jul 22, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Jul 22, 2024
@guibranco
Copy link
Member

@dependabot squash and merge

Copy link

korbit-ai bot commented Jul 22, 2024

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

Copy link
Contributor

Build debug & Version bump: 🔰 Building GHActionsCI.sln

Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 22, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link
Contributor

Build debug & Version bump: 🎯 Build succeeded - New version: 1.0.909.1

Copy link
Contributor

Build debug & Version bump:Successfully builded and patched GHActionsCI.sln.

Version: #️⃣ 1.0.909.1
Warnings: ⚠️

D:\a\POC-GHActions-CI-NetFramework\POC-GHActions-CI-NetFramework\Src\GHActionsCI\Program.cs(27,20): warning S1118: Add a 'protected' constructor or the 'static' keyword to the class declaration. (https://rules.sonarsource.com/csharp/RSPEC-1118) [D:\a\POC-GHActions-CI-NetFramework\POC-GHActions-CI-NetFramework\Src\GHActionsCI\GHActionsCI.csproj]

Copy link

codeclimate bot commented Jul 22, 2024

Code Climate has analyzed commit 2cc11e1 and detected 0 issues on this pull request.

View more on Code Climate.

@guibranco guibranco merged commit 9a3c59b into main Jul 22, 2024
14 of 16 checks passed
@guibranco guibranco deleted the dependabot/nuget/CrispyWaffle-7.0.83 branch July 22, 2024 11:46
Copy link
Contributor

Infisical secrets check: 🚨 Secrets leaked!

Scan results:

11:46AM INF scanning for exposed secrets...
11:46AM INF 231 commits scanned.
11:46AM INF scan completed in 444ms
11:46AM WRN leaks found: 8

Scan report:

RuleID,Commit,File,SymlinkFile,Secret,Match,StartLine,EndLine,StartColumn,EndColumn,Author,Message,Date,Email,Fingerprint
generic-api-key,6ae2eef24bb4d76a9af06c287d8e6c6443d86cca,Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj,,REDACTED,"KeyToken=REDACTED""",42,42,82,107,net-framework-updater[bot],"Packages update (CI) (#202)

Co-authored-by: net-framework-updater[bot] <136581072+net-framework-updater[bot]@users.noreply.github.com>
Co-authored-by: Guilherme Branco Stracini <guilherme@guilhermebranco.com.br>",2023-12-04T18:03:11Z,136581072+net-framework-updater[bot]@users.noreply.github.com,6ae2eef24bb4d76a9af06c287d8e6c6443d86cca:Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj:generic-api-key:42
generic-api-key,6ae2eef24bb4d76a9af06c287d8e6c6443d86cca,Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj,,REDACTED,"KeyToken=REDACTED""",46,46,90,115,net-framework-updater[bot],"Packages update (CI) (#202)

Co-authored-by: net-framework-updater[bot] <136581072+net-framework-updater[bot]@users.noreply.github.com>
Co-authored-by: Guilherme Branco Stracini <guilherme@guilhermebranco.com.br>",2023-12-04T18:03:11Z,136581072+net-framework-updater[bot]@users.noreply.github.com,6ae2eef24bb4d76a9af06c287d8e6c6443d86cca:Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj:generic-api-key:46
generic-api-key,ef9f3e4b5a23d5c6f047bb79f8514d53eb7b990a,Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj,,REDACTED,"KeyToken=REDACTED""",42,42,83,108,net-framework-updater[bot],"Packages update (CI) (#185)

Co-authored-by: net-framework-updater[bot] <136581072+net-framework-updater[bot]@users.noreply.github.com>",2023-11-05T13:34:32Z,136581072+net-framework-updater[bot]@users.noreply.github.com,ef9f3e4b5a23d5c6f047bb79f8514d53eb7b990a:Test/GHActionsCI.UnitTests/GHActionsCI.UnitTests.csproj:generic-api-key:42
generic-api-key,b529aaec8e2f6d2cd7aed2b8f94e31f4ee7f19bf,.github/workflows/build.yml,,REDACTED,password: REDACTED,49,49,12,0,Guilherme Branco Stracini,Update build.yml,2022-09-12T13:20:01Z,guilherme@guilhermebranco.com.br,b529aaec8e2f6d2cd7aed2b8f94e31f4ee7f19bf:.github/workflows/build.yml:generic-api-key:49
generic-api-key,48c1a06efe07f54cd8c1fe9f6f20979caffa7633,.github/workflows/build.yml,,REDACTED,password: REDACTED,43,43,12,0,Guilherme Branco Stracini,Update build.yml,2020-09-03T01:03:31Z,guilherme@guilhermebranco.com.br,48c1a06efe07f54cd8c1fe9f6f20979caffa7633:.github/workflows/build.yml:generic-api-key:43
generic-api-key,698cfc7c181c64a4970f811877c8065e3e18fae0,.github/workflows/publishFTP.yml,,REDACTED,password: REDACTED ,20,20,12,47,Guilherme Branco Stracini,Create publishFTP.yml,2020-09-03T00:40:17Z,guilherme@guilhermebranco.com.br,698cfc7c181c64a4970f811877c8065e3e18fae0:.github/workflows/publishFTP.yml:generic-api-key:20
generic-api-key,a88f791d81edc7a6ca7a9549c351d28507dc95eb,.github/workflows/build.yml,,REDACTED,password: REDACTED ,35,35,12,47,Guilherme Branco Stracini,Update build.yml,2020-09-03T00:33:56Z,guilherme@guilhermebranco.com.br,a88f791d81edc7a6ca7a9549c351d28507dc95eb:.github/workflows/build.yml:generic-api-key:35
generic-api-key,bd236a4682d40467de1340acc16d3965bc5475b7,.github/workflows/build.yml,,REDACTED,password: REDACTED ,35,35,16,51,Guilherme Branco Stracini,Update build.yml,2020-09-03T00:26:53Z,guilherme@guilhermebranco.com.br,bd236a4682d40467de1340acc16d3965bc5475b7:.github/workflows/build.yml:generic-api-key:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot dependencies korbit-code-analysis .NET Pull requests that update .net code nuget NuGet package size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant