Skip to content

Commit

Permalink
Rollup merge of rust-lang#89335 - mbrubeck:range-is-sorted, r=cuviper
Browse files Browse the repository at this point in the history
Optimize is_sorted for Range and RangeInclusive

The [`Step`] trait guarantees that `Range<impl Step>` yields items in sorted order.  We can override `Iterator::is_sorted` based on this guarantee, as we already do for `Iterator::min` and `max`.

Thank you to `@fiveseven-lambda` who pointed this out [on the Rust Users Forum](https://users.rust-lang.org/t/is-sorted-method-in-impl-iterator-for-range/64717).

[`Step`]: https://doc.rust-lang.org/stable/std/iter/trait.Step.html
  • Loading branch information
GuillaumeGomez committed Sep 29, 2021
2 parents 164477d + 830ecbd commit dc9bf70
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions library/core/src/iter/range.rs
Expand Up @@ -672,6 +672,11 @@ impl<A: Step> Iterator for ops::Range<A> {
self.next_back()
}

#[inline]
fn is_sorted(self) -> bool {
true
}

#[inline]
#[doc(hidden)]
unsafe fn __iterator_get_unchecked(&mut self, idx: usize) -> Self::Item
Expand Down Expand Up @@ -1095,6 +1100,11 @@ impl<A: Step> Iterator for ops::RangeInclusive<A> {
fn max(mut self) -> Option<A> {
self.next_back()
}

#[inline]
fn is_sorted(self) -> bool {
true
}
}

#[stable(feature = "inclusive_range", since = "1.26.0")]
Expand Down

0 comments on commit dc9bf70

Please sign in to comment.