Fix memory leaks in pyVaultNodeOperationCallback. #1004
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long standing issue has been mysterious "key only" memory leaks when the
plResManager
destructs, as seen in the leak report in plasmadbg.log:These leaks correspond to the xSimpleImager.py script, which uses vaultOperation callbacks. The vault operation callback C++ code was incorrectly assuming that
PyObject_GetAttrString()
would return a borrowed reference and not decrementing the reference count. This is fixed by usingpyObjectRef
to correct and clarify the reference counting.Unfortunately, Python still reports errors on shutdown, but this is a good step toward correcting them.