Make AsyncThreadTimedJoin available on other platforms. #1011
Conversation
On Linux, this uses pthread_timedjoin_np(). For other OSes (not Windows or Linux), we just fall back to a blocking join :/
| if (rc == WAIT_TIMEOUT) | ||
| LogMsg(kLogDebug, "Thread did not terminate after {} ms", timeoutMs); | ||
| thread.detach(); | ||
| #elif defined(HS_BUILD_FOR_LINUX) |
There was a problem hiding this comment.
I wonder if this should be a cmake check based on the provider of Threads::Threads. Doesn't pthread exist and offer this functionality on BSD?
There was a problem hiding this comment.
pthreads exist on BSD and Darwin, but the pthread_timedjoin_np is a non-portable extension, which AFAIK is Linux-only.
There was a problem hiding this comment.
Some BSDs seem to advertise pthread_timedjoin_np in their manpages, but Darwin support is probably more important :/. Example: https://www.freebsd.org/cgi/man.cgi?pthread_join
There was a problem hiding this comment.
Ah, good to know... Perhaps a better way to do this would be to test for the presence of the function. If I don't forget, I'll make a PR in the future to do that
On Linux, this uses
pthread_timedjoin_np(). For other OSes (not Windows or Linux), we just fall back to a blocking join :/