-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar Clothing Fix #116
Avatar Clothing Fix #116
Conversation
I'm definitely in favour of this code getting in, but I don't know how I feel about making pull requests for other peoples' code. I'd feel better if this had already been merged into OU's codebase, or if someone contacted Skoader. As far as I know, he hasn't even made a pull request to OU yet. |
I get the impression that he's mostly playing in his own sandbox and isn't really interested in issuing pull requests to either this repository or OU's. But, then again, that's just my impression. |
I just pinged him again (https://bitbucket.org/Skoader/cwe-skoader/changeset/896909449d99#comment-7921). In fact, I thought about doing that just a few days ago, since this is a fix I would really like to have in both H-uru/Plasma and CWE-ou. For what it’s worth, here’s my port from when I tested it: cwalther/Plasma@ 0ff9a10ca9897bad50c9c77f9e6c6dff679615a9. As far as I can see, the only piece of commit metadata you didn’t preserve is the authoring date (plus an extra line break in the commit message). If Skoader is OK with that, I’d say go for it. Also, you have some stray whitespace at the end of the last line of code. |
Thanks for the heads up cwalther. I've been busy but I'll issue a pull request with OU tomorrow. |
Bounds type needs be checked after refreshing the bsp tree.
@Skoader Thanks! You're doing some good work in your fork that I think is very beneficial. I'll try to keep up with your progress. @cwalther I missed the commit date unfortunately. I added a newline to the commit message so that we can use github's nice message formatting. Furthermore, I used spaces instead of tabs in the code. The extra whitespace is troubling, so I'll amend this commit to fix that. |
@Skoader Thanks! I'm definitely 👍 on this :) |
Avatar Clothing Fix
Avatar Clothing Fix
Avatar Clothing Fix
change literal from octal to decimal
Ported from Skoader's repository @ https://bitbucket.org/Skoader/cwe-skoader/changeset/896909449d99
The original contained tabs, so I did not concern myself with preserving commit metadata. This fixes the annyoning one-frame untextured avatar when switching from 1st person to 3rd person.