Warning cleanup #225
Merged
Warning cleanup #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not delete pfPython/Pch.cpp. That file is responsible for generating the precompiled header. |
Deledrius
pushed a commit
to Deledrius/Plasma
that referenced
this pull request
Dec 4, 2012
Warning cleanup
Hoikas
added a commit
to Hoikas/Plasma
that referenced
this pull request
Dec 13, 2012
Warning cleanup
Hoikas
added a commit
to Hoikas/Plasma
that referenced
this pull request
Dec 22, 2012
As pointed out in H-uru#225, Pch.cpp looks suspiciously like a garbage file when precompiled headers are disabled in cmake. To solve that, I have changed the precompiled header function to add the Pch source files only when pch is enabled. This should prevent future accidents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some of the more interesting warnings that VS currently emits during compile. Many are related to the hsBool removal (faulty assumptions about hsBool being larger than one bit), but there's also some other fun stuff. Empty .obj files also emit a warning, which is why some empty .cpp file removal is also included ;)