Refactor RegistryKeyList #264
Conversation
|
Updated with a few small fixes |
| } | ||
| } | ||
| auto it = std::find_if(fKeys.begin(), fKeys.end(), | ||
| [&] (plKeyImp* key) { return key->GetName().CompareI(keyName) == 0; } |
There was a problem hiding this comment.
Personally, I like to avoid the "capture everything" forms in lambdas... You need keyName, so just capture [&keyName] >.>
There was a problem hiding this comment.
Whereas I prefer to capture everything and let the compiler figure it out 😄. I feel that explicit capture list are somewhat redundant/tedious and have the potential to introduce stupid compiler errors (if you forget to change the capture list when updating the lambda body). If we have a consensus that explicit capturing is better, I'd be glad to change it though.
There was a problem hiding this comment.
For lambdas that are used inline like this, and that we know are not going to be saved and called later, I think the implicit "capture it all by reference" usage is fine.
This is in preparation for page patching. The old code kept dynamic (programatically created) and serialized keys separate. This had the potential to reorder the key list during the application of a patch. This is separate from the prp-patches branch to facillitate review.
This is in preparation for page patching. The old code kept dynamic (programatically created) and serialized keys separate. This had the potential to reorder the key list during the application of a patch.
This is separate from the prp-patches branch to facillitate review.