Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trickle of PCH #284

Merged
merged 2 commits into from
Feb 13, 2013
Merged

Trickle of PCH #284

merged 2 commits into from
Feb 13, 2013

Conversation

Hoikas
Copy link
Member

@Hoikas Hoikas commented Jan 30, 2013

  • Fixes an oversight that would cause Release and Debug builds' precompiled header binaries to clobber each other until Visual Studio gave up and spewed errors.
  • Adds a basic precompiled header to CoreLib. This will really only help dinosaurs (such as Core 2 Duos).

@Hoikas
Fix Debug/Release PCH Battles
194f44b 
Don't specify the filename ourselves... Let VS figure it out.
@Hoikas
CoreLib Precompiled Header
fc43c62 
NOTE: I used a different header name this time because CoreLib headers are
visible top-level to the rest of the codebase.
@Hoikas
Copy link
Member Author

Hoikas commented Feb 4, 2013

Updated.

As a bonus, plProduct::ProductString() now works properly for Debug builds. Before, it did not include HeadSpin.h, which is where HS_DEBUGGING is defined.

zrax
zrax reviewed Feb 5, 2013
View reviewed changes
Sources/Plasma/CoreLib/plString.cpp
#include <cstring>
#include <cstdlib>
#include <wchar.h>
#include <memory>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to verify that cstring and cstdlib aren't needed for GCC/clang before removing them

EDIT: never mind... I see that they're included in HeadSpin.h

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. No need to bring them in twice...

Hoikas added a commit that referenced this pull request Feb 13, 2013
@Hoikas
Merge pull request #284 from Hoikas/pch
9e87967 
Trickle of PCH
@Hoikas Hoikas merged commit 9e87967 into H-uru:master Feb 13, 2013
@Hoikas Hoikas deleted the pch branch February 13, 2013 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hoikas @zrax