plPXConvert::Validate to compile time #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seriously? Offsetof has been around for a long time, and eap added a compiler_assert for his crazy netcode. There's no excuse for that to be happening at runtime.
|
👍 |
branan
pushed a commit
that referenced
this pull request
May 23, 2013
plPXConvert::Validate to compile time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor plPXConvert::Validate to be compile-time checks. I am saddened by the fact that this was a runtime check, especially given the availability of offsetof (and an alternative in CoreLib) and eap's old compiler_assert.