More Skinning Improvements #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated main PR text with actual profiling results. |
|
👍 This looks good to me as far as I understand it, and I noticed no regressions in testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More aligned loading goodness and the removal of the aligned-float-array hack in the SSE3 macro in most cases. I didn't bother optimizing the skinned-uv case because it's never used.
This yields a modest improvement on my Wolfdale CPU. Improvements will likely be more dramatic on older CPUs.
Side by side with 7 avatars on screen: this branch takes 1.65ms to complete the skinning loop while master completes skinning in 1.85ms. Improvements are more impressive when only one client is running.